8000 [MPS] Fix crash when mm is invoked with mixed dtypes by malfet · Pull Request #143948 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[MPS] Fix crash when mm is invoked with mixed dtypes #143948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[MPS] Fix crash when mm is invoked with mixed dtypes #143948

wants to merge 3 commits into from

Conversation

malfet
Copy link
Contributor
@malfet malfet commented Dec 28, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

Simply by copy-n-pasting check from

pytorch/aten/src/ATen/native/cuda/Blas.cpp

Lines 254 to 257 in a7915c5

TORCH_CHECK(
mat1.dtype() == mat2.dtype(),
"expected mat1 and mat2 to have the same dtype, but got: ", mat1.dtype(), " != ", mat2.dtype()
)

@malfet
Update
caa6f48 
[ghstack-poisoned]
@malfet malfet requested a review from kulinseth as a code owner December 28, 2024 22:06
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Dec 28, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/143948

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 1fd7ded with merge base e1abbe1 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Dec 28, 2024
@malfet malfet mentioned this pull request Dec 28, 2024
Closed
This was referenced Dec 30, 2024
Closed
Closed
Closed
@malfet malfet added the topic: bug fixes topic category label Dec 30, 2024
@malfet
Copy link
Contributor Author
malfet commented Dec 30, 2024

@pytorchbot merge -f "no need to run a trunk testing"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Dec 30, 2024
@malfet @pytorchmergebot
[MPS] Fix torch.add(x,y, alpha=2) crash (#143949)
c27c788 
TODO: as followup PR replace this weird logic with shaders

Fixes #143932

Pull Request resolved: #143949
Approved by: https://github.com/Skylion007
ghstack dependencies: #143948
@malfet malfet mentioned this pull request Dec 30, 2024
Closed
pytorchmergebot pushed a commit that referenced this pull request Dec 31, 2024
@malfet @pytorchmergebot
[MPSInductor] Fix index generation for transpose (#143973)
11bb94b 
Alas, PythonPrinter would not work here, not would CppPrinter, so start building MetalPrinter.

`pytest test/inductor/test_torchinductor.py -k _mps` score is 474 failed, 277 passed, 32 skipped
Before this change:
`pytest test/inductor/test_torchinductor.py -k _mps` reported 506 failed, 245 passed, 32 skipped

Pull Request resolved: #143973
Approved by: https://github.com/jansel
ghstack dependencies: #143948, #143949
pytorchmergebot pushed a commit that referenced this pull request Dec 31, 2024
@malfet @pytorchmergebot
[MPSInductor] Implement minimum and maximum ops (#143977)
f0f09bb 
By calling `metal::min` and `metal::max` respectively with argument
typecast to a common type to avoid ambiguous calls errors

TODO: Implement NaN propagation for both eager and compile, see #143976

`pytest test/inductor/test_torchinductor.py -k _mps` score is 460 failed, 291 passed, 32 skipped

Pull Request resolved: #143977
Approved by: https://github.com/jansel
ghstack dependencies: #143948, #143949, #143973
pytorchmergebot pushed a commit that referenced this pull request Dec 31, 2024
@malfet @pytorchmergebot
[MPSInductor] Fix multiple kernel generation (#143998)
5ef0de7 
At the moment by generating multiple MetalLibraries

`pytest test/inductor/test_torchinductor.py -k _mps` score is 434 failed, 317 passed, 32 skipped

Pull Request resolved: #143998
Approved by: https://github.com/jansel, https://github.com/ruidazeng
ghstack dependencies: #143948, #143949, #143973, #143977
@github-actions github-actions bot deleted the gh/malfet/94/head branch February 1, 2025 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@kulinseth kulinseth Awaiting requested review from kulinseth

Assignees
No one assigned
Labels
ciflow/mps Run MPS tests (subset of trunk) Merged release notes: mps Release notes category topic: bug fixes topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@malfet @pytorchmergebot @Skylion007
0