[AOTI] Emit a CMakeLists.txt when package_cpp_only #143352
Conversation
Summary: Emit a CMakeLists.txt with compile and link options when package_cpp_only is specified. After unzipping AOTI generated .pt2 package file, user can manually build the generated model code in their local environment. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/143352
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Summary: Emit a CMakeLists.txt with compile and link options when package_cpp_only is specified. After unzipping AOTI generated .pt2 package file, user can manually build the generated model code in their local environment. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang aakhundov [ghstack-poisoned]
Summary: Emit a CMakeLists.txt with compile and link options when package_cpp_only is specified. After unzipping AOTI generated .pt2 package file, user can manually build the generated model code in their local environment. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang aakhundov [ghstack-poisoned]
Summary: Emit a CMakeLists.txt with compile and link options when package_cpp_only is specified. After unzipping AOTI generated .pt2 package file, user can manually build the generated model code in their local environment. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang aakhundov [ghstack-poisoned]
| @@ -176,6 +180,60 @@ def forward(self, x, y): | |||
| ) | |||
| self.check_model(Model(), example_inputs) | |||
|
|
|||
| def test_compile_after_package(self): | |||
There was a problem hiding this comment.
It would be nice to skip skip tests if cmake or make could not be found on the tester
| definitions = " ".join(self._build_option.get_definations()) | ||
| contents = textwrap.dedent( | ||
| f""" | ||
| cmake_minimum_required(VERSION 3.18 FATAL_ERROR) |
There was a problem hiding this comment.
It does not feel like it needs any of 3.18 feature, so why put this constraint here?
There was a problem hiding this comment.
Copied from the main CMakeLists.txt in pytorch, but I agree it seems unnecessary here.
There was a problem hiding this comment.
Hmm, it actually causes the cuda test fail to compile. Not sure why, but I am keeping this.
torch/_inductor/cpp_builder.py
Outdated
| set(CMAKE_CXX_STANDARD 17) | ||
|
|
||
| # Set the compiler | ||
| set(CMAKE_CXX_COMPILER {self._compiler}) |
There was a problem hiding this comment.
Why this is is needed? Cmake should be able to auto-detect compiler you are using. This will also make AOTI C++ packaging non-portable, i.e. imagine it was generated on machine with gcc-9 as host compiler, but will be compiled on machine with gcc-10
Summary: Emit a CMakeLists.txt with compile and link options when package_cpp_only is specified. After unzipping AOTI generated .pt2 package file, user can manually build the generated model code in their local environment. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang aakhundov [ghstack-poisoned]
|
@desertfire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Emit a CMakeLists.txt with compile and link options when package_cpp_only is specified. After unzipping AOTI generated .pt2 package file, user can manually build the generated model code in their local environment. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang aakhundov Differential Revision: [D67458526](https://our.internmc.facebook.com/intern/diff/D67458526) [ghstack-poisoned]
|
@desertfire has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -m 'Sorry for reverting your change but the new test is failing on ROCm' -c nosignal inductor/test_aot_inductor_package.py::TestAOTInductorPackageCpp_cpu::test_compile_after_package GH job link HUD commit link |
|
@pytorchbot successfully started a revert job. Check the current status here. |
This reverts commit 429f4cd. Reverted #143352 on behalf of https://github.com/huydhn due to Sorry for reverting your change but the new test is failing on ROCm ([comment](#143352 (comment)))
|
@desertfire your PR has been successfully reverted. |
Summary: Emit a CMakeLists.txt with compile and link options when package_cpp_only is specified. After unzipping AOTI generated .pt2 package file, user can manually build the generated model code in their local environment. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames chauhang aakhundov Differential Revision: [D67458526](https://our.internmc.facebook.com/intern/diff/D67458526) [ghstack-poisoned]
|
Close to reland in #143680 |
Stack from ghstack (oldest at bottom):
Summary: Emit a CMakeLists.txt with compile and link options when package_cpp_only is specified. After unzipping AOTI generated .pt2 package file, user can manually build the generated model code in their local environment.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @chauhang @aakhundov
Differential Revision: D67458526