8000 [FSDP2] Clamp `reduce_dtype` in lazy init by awgu · Pull Request #143297 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[FSDP2] Clamp reduce_dtype in lazy init #143297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[FSDP2] Clamp reduce_dtype in lazy init #143297

wants to merge 2 commits into from

Conversation

awgu
Copy link
Collaborator
@awgu awgu commented Dec 16, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

fixes #143277 by moving the clamp of reduce_dtype to None to lazy init (same place as where param_dtype can be clamped to None)

cc @H-Huang @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o
< 8000 !-- '"` -->
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Dec 16, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/143297

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e78894a with merge base e4d2e81 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/inductor oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (fsdp) release notes category labels Dec 16, 2024
@awgu awgu added release notes: distributed (fsdp2) release notes category and removed release notes: distributed (fsdp) release notes category labels Dec 16, 2024
Update on "[FSDP2] Clamp reduce_dtype in lazy init"
e78894a 
#143277

cc H-Huang kwen2501 wanchaol fegin fduwjj wz337 wconstab d4l3k c-p-i-o

[ghstack-poisoned]
awgu pushed a commit that referenced this pull request Dec 16, 2024
[FSDP2] Clamp reduce_dtype in lazy init
58f00ec 
ghstack-source-id: b77f0b0
Pull Request resolved: #143297
@awgu awgu marked this pull request as ready for review December 16, 2024 20:41
@awgu awgu requested a review from weifengpy December 16, 2024 20:41
@awgu awgu added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 16, 2024
@awgu
Copy link
Collaborator Author
awgu commented Dec 17, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/awgu/665/head branch January 16, 2025 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weifengpy weifengpy weifengpy approved these changes

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (fsdp2) release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@awgu @pytorchmergebot @weifengpy
0