8000 support slicing with symints in non-strict by avikchaudhuri · Pull Request #143217 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

support slicing with symints in non-strict #143217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

support slicing with symints in non-strict #143217

wants to merge 3 commits into from

Conversation

avikchaudhuri
Copy link
Contributor
@avikchaudhuri avikchaudhuri commented Dec 13, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

Differential Revision: D67215745

@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Dec 13, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/143217

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 4d8358c with merge base dbe4b69 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67215745

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 13, 2024
@avikchaudhuri avikchaudhuri changed the title support torch.tensor on symints in non-strict support slicing with symints in non-strict Dec 13, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67215745

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67215745

avikchaudhuri added a commit that referenced this pull request Dec 14, 2024
@avikchaudhuri
support slicing with symints in non-strict
0c650e2 
Pull Request resolved: #143217
ghstack-source-id: 258152326

Differential Revision: [D67215745](https://our.internmc.facebook.com/intern/diff/D67215745/)
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

aditew01 pushed a commit to aditew01/pytorch that referenced this pull request Dec 18, 2024
@avikchaudhuri @aditew01
support slicing with symints in non-strict (pytorch#143217)
9b200cd 
Differential Revision: [D67215745](https://our.internmc.facebook.com/intern/diff/D67215745/)
Pull Request resolved: pytorch#143217
Approved by: https://github.com/tugsbayasgalan
@github-actions github-actions bot deleted the gh/avikchaudhuri/37/head branch January 14, 2025 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tugsbayasgalan tugsbayasgalan tugsbayasgalan approved these changes

@zhxchen17 zhxchen17 Awaiting requested review from zhxchen17

@ydwu4 ydwu4 Awaiting requested review from ydwu4

@angelayi angelayi Awaiting requested review from angelayi

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged release notes: export
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@avikchaudhuri @facebook-github-bot @pytorchmergebot @tugsbayasgalan
0