Enable AArch64 CI scripts to be used for local dev #143190
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/143190
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 82e4c50 with merge base 7482eb2 ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
bdb74e2 to
f424c67
Compare
|
@pytorchbot label "topic: not user facing" |
f424c67 to
afded46
Compare
|
Can I get a review on this please? |
|
@pytorchbot label "module: arm" |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
|
@pytorchbot label "ciflow/linux-aarch64" |
|
To add the ciflow label This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows. |
|
@malfet - could you please approve the CI? We don't have enough permissions the approve it. |
|
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
|
Successfully rebased |
afded46 to
6e5628b
Compare
|
@pytorchbot label "ciflow/linux-aarch64" |
|
Oh I now see the "Enable CI Workflow" button after the rebase, thanks @aditew01! |
| "--shallow-submodules", | ||
| ] | ||
| ) | ||
| acl_checkout_dir = os.getenv("ACL_SOURCE_DIR", "ComputeLibrary") |
There was a problem hiding this comment.
I don't see why the ACL_SOURCE_DIR is needed here.
This script is meant to be run inside the docker container and one can make it pick up their custom local ACL directory by mounting the docker container to it (along with the other changes introduced in this PR).
For development outside docker, isn't ACL_ROOT_DIR in setup.py here enough?
|
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
- Allow user to specify a custom Arm Compute Library directory with the ACL_SOURCE_DIR environment variable, which is then built rather than checking out a clean copy - Remove `setup.py clean` in build. The CI environment should be clean already, removing this enables incremental rebuilds - Use all cores for building ComputeLibrary - Remove restriction of building with MAX_JOBS=5 on CPU backend Mostly a port of pytorch/builder#2028 with the conda part removed, because aarch64_ci_setup.sh has changed and can now handle being called twice. Co-authored-by: David Svantesson-Yeung <David.Svantesson-Yeung@arm.com> Co-authored-by: Fadi Arafeh <Fadi.Arafeh@arm.com>
|
Successfully rebased |
6e5628b to
82e4c50
Compare
setup.py cleanin build. The CI environment should be clean already, removing this enables incremental rebuildsMostly a port of pytorch/builder#2028 with the conda part removed, because aarch64_ci_setup.sh has changed and can now handle being called twice.
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @jerryzh168 @malfet @snadampal @milpuz01 @aditew01 @nikhil-arm @fadara01