8000 [ROCm] Improve performance of reduce sum for 3D shapes by doru1004 · Pull Request #143137 · pytorch/pytorch · GitHub
[go: up one dir, main page]

Skip to content

[ROCm] Improve performance of reduce sum for 3D shapes #143137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

doru1004
Copy link
Contributor
@doru1004 doru1004 commented Dec 12, 2024

Copy link
pytorch-bot bot commented Dec 12, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/143137

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures

As of commit c126fd3 with merge base 6d779d0 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added module: rocm AMD GPU support for Pytorch release notes: cuda release notes category labels Dec 12, 2024
@colesbury colesbury requested a review from jeffdaily December 12, 2024 21:28
@colesbury colesbury added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Dec 12, 2024
@jeffdaily jeffdaily added the ciflow/rocm Trigger "default" config CI on ROCm label Dec 12, 2024
@jeffdaily
Copy link
Collaborator

@pytorchbot merge -f "a one-line change inside an #ifdef USE_ROCM, all ROCm CI passed"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

bluenote10 pushed a commit to bluenote10/pytorch that referenced this pull request Dec 14, 2024
caaatch22 pushed a commit to caaatch22/pytorch that referenced this pull request Jan 6, 2025
caaatch22 pushed a commit to caaatch22/pytorch that referenced this pull request Jan 7, 2025
pruthvistony pushed a commit to ROCm/pytorch that referenced this pull request Jan 16, 2025
… (#1839)

Improve performance of reduce sum for 3D shapes.

Pull Request resolved: pytorch#143137
Approved by: https://github.com/jeffdaily, https://github.com/eqy

Co-authored-by: Doru Bercea <doru.bercea@amd.com>
rocm-mici pushed a commit to ROCm/pytorch that referenced this pull request Jan 16, 2025
… (#1839)

Improve performance of reduce sum for 3D shapes.

Pull Request resolved: pytorch#143137
Approved by: https://github.com/jeffdaily, https://github.com/eqy

Co-authored-by: Doru Bercea <doru.bercea@amd.com>
pruthvistony pushed a commit to ROCm/pytorch that referenced this pull request Jan 16, 2025
…m for 3D shapes (pytorch#143137) (#1843)

Cherry-pick of #1839

Co-authored-by: Jerry Mannil <65309407+jerrymannil@users.noreply.github.com>
Co-authored-by: Doru Bercea <doru.bercea@amd.com>
rocm-mici pushed a commit to ROCm/pytorch that referenced this pull request Jan 16, 2025
… (#1839)

Improve performance of reduce sum for 3D shapes.

Pull Request resolved: pytorch#143137
Approved by: https://github.com/jeffdaily, https://github.com/eqy

Co-authored-by: Doru Bercea <doru.bercea@amd.com>
jerrymannil pushed a commit to ROCm/pytorch that referenced this pull request Feb 6, 2025
jithunnair-amd pushed a commit to ROCm/pytorch that referenced this pull request Feb 19, 2025
…m for 3D shapes (pytorch#143137) (#1843)

Cherry-pick of #1839

Co-authored-by: Jerry Mannil <65309407+jerrymannil@users.noreply.github.com>
Co-authored-by: Doru Bercea <doru.bercea@amd.com>
(cherry picked from commit f929e0d)
jithunnair-amd pushed a commit to ROCm/pytorch that referenced this pull request Feb 20, 2025
…m for 3D shapes (pytorch#143137) (#1843)

Cherry-pick of #1839

Co-authored-by: Jerry Mannil <65309407+jerrymannil@users.noreply.github.com>
Co-authored-by: Doru Bercea <doru.bercea@amd.com>
(cherry picked from commit f929e0d)
jithunnair-amd pushed a commit to ROCm/pytorch that referenced this pull request Mar 17, 2025
… (#1839)

Improve performance of reduce sum for 3D shapes.

Pull Request resolved: pytorch#143137
Approved by: https://github.com/jeffdaily, https://github.com/eqy

Co-authored-by: Doru Bercea <doru.bercea@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/rocm Trigger "default" config CI on ROCm Merged module: rocm AMD GPU support for Pytorch open source release notes: cuda release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
0