fix dynamo nn module stack fqn #142823
Closed
fix dynamo nn module stack fqn #142823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dynamo can produce sources that have funny patterns in their `.name()` that break `nn_module_stack` fqns. Here we address them explicitly. Fixes #141939 Differential Revision: [D67064189](https://our.internmc.facebook.com/intern/diff/D67064189/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142823
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 6bb19ec with merge base 2b105de ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D67064189 |
avikchaudhuri
added a commit
that referenced
this pull request
Dec 11, 2024
Dynamo can produce sources that have funny patterns in their `.name()` that break `nn_module_stack` fqns. Here we address them explicitly. Fixes #141939 Differential Revision: [D67064189](https://our.internmc.facebook.com/intern/diff/D67064189/) ghstack-source-id: 257572754 Pull Request resolved: #142823
Dynamo can produce sources that have funny patterns in their `.name()` that break `nn_module_stack` fqns. Added a test that used to have `._modules` inside nn_module_stack fqns, now doesn't. (Unfortunately couldn't repro a case mentioned in the GH issue where `.slice(...)` is claimed to appear as well.) Fixes #141939 Differential Revision: [D67064189](https://our.internmc.facebook.com/intern/diff/D67064189/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D67064189 |
avikchaudhuri
added a commit
that referenced
this pull request
Dec 11, 2024
Pull Request resolved: #142823 Dynamo can produce sources that have funny patterns in their `.name()` that break `nn_module_stack` fqns. Here we address them explicitly. Fixes #141939 Differential Revision: [D67064189](https://our.internmc.facebook.com/intern/diff/D67064189/) ghstack-source-id: 257599607
Dynamo can produce sources that have funny patterns in their `.name()` that break `nn_module_stack` fqns. Added a test that used to have `._modules` inside nn_module_stack fqns, now doesn't. (Unfortunately couldn't repro a case mentioned in the GH issue where `.slice(...)` is claimed to appear as well.) Fixes #141939 Differential Revision: [D67064189](https://our.internmc.facebook.com/intern/diff/D67064189/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D67064189 |
avikchaudhuri
added a commit
that referenced
this pull request
Dec 11, 2024
Pull Request resolved: #142823 Dynamo can produce sources that have funny patterns in their `.name()` that break `nn_module_stack` fqns. Here we address them explicitly. Fixes #141939 ghstack-source-id: 257610691 Differential Revision: [D67064189](https://our.internmc.facebook.com/intern/diff/D67064189/)
pianpwk
approved these changes
Dec 11, 2024
As I said in the summary, there's another case that was reported (slice call) but I can't seem to repro it. |
zhxchen17
approved these changes
Dec 11, 2024
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
bluenote10
pushed a commit
to bluenote10/pytorch
that referenced
this pull request
Dec 14, 2024
Dynamo can produce sources that have funny patterns in their `.name()` that break `nn_module_stack` fqns. Added a test that used to have `._modules` inside nn_module_stack fqns, now doesn't. (Unfortunately couldn't repro a case mentioned in the GH issue where `.slice(...)` is claimed to appear as well.) Fixes pytorch#141939 Differential Revision: [D67064189](https://our.internmc.facebook.com/intern/diff/D67064189/) Pull Request resolved: pytorch#142823 Approved by: https://github.com/pianpwk, https://github.com/zhxchen17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Dynamo can produce sources that have funny patterns in their
.name()that breaknn_module_stackfqns. Added a test that used to have._modulesinside nn_module_stack fqns, now doesn't. (Unfortunately couldn't repro a case mentioned in the GH issue where.slice(...)is claimed to appear as well.)Fixes #141939
Differential Revision: D67064189