8000 Add noncontiguous OpInfo tests for MPS by skotapati · Pull Request #142202 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Add noncontiguous OpInfo tests for MPS #142202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 24 commits into from
Closed

Add noncontiguous OpInfo tests for MPS #142202

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
20e6385
MPS OpInfo core requirements
skotapati Jan 15, 2025
87fa0ad
Enable test_noncontiguous_samples, refactored for clarity
skotapati Jan 17, 2025
5d11f70
Formatting fixes
skotapati Jan 17, 2025
1049b6f
Allow MacOS14
skotapati Jan 17, 2025
063633f
Fix syntax error, move mps_utils to _internal
skotapati Jan 17, 2025
47255f4
Remove dummy code
skotapati Jan 17, 2025
73368e6
Remove debug code
skotapati Jan 17, 2025
26d084d
Move mps_utils.py
skotapati Jan 17, 2025
39e6814
Add xfails for macos14
skotapati Jan 17, 2025
7f579c9
Add xFail for unimplemented ops
skotapati Jan 23, 2025
0749d25
Adjust TORCH_CHECK calls to better catch unimplemented ops & dtypes
skotapati Jan 24, 2025
7cd9cca
Add additional xfails for test_out & unimplemented ops + formatting f…
skotapati Jan 24, 2025
e9e4303
Additional formatting fixes
skotapati Jan 24, 2025
c1c4378
Variant fixes, add remaining xfails for MacOS15
skotapati Jan 24, 2025
6d977c0
Additional formatting fixes
skotapati Jan 24, 2025
118cd38
Add MacOS14 xfails
skotapati Jan 24, 2025
2e58330
Additional MacOS14 xfails
skotapati Jan 24, 2025
0162979
Add (hopefully) all remaining MacOS14 xfail info for test_out
skotapati Jan 24, 2025
8cb7efe
Linter fixes
skotapati Jan 24, 2025
90cdab0
Additional fixes
skotapati Jan 24, 2025
722b1d7
Formatting fixes
skotapati Jan 24, 2025
54d90e9
Revert unnecessary change
skotapati Jan 24, 2025
d6e2db8
Formatting changes
skotapati Jan 28, 2025
d9f9e22
Split out unimplemented ops for easier tracking
skotapati Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Formatting fixes
  • Loading branch information
@skotapati @pytorchmergebot
skotapati authored and pytorchmergebot committed Jan 28, 2025
commit 5d11f703f0c67b41dcd47b6008816f2a0842b17c
2 changes: 2 additions & 0 deletions test/test_ops.py
96E1 View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@
if IS_MACOS:
mps_op_db(op_db)


def reduction_dtype_filter(op):
if (
not isinstance(op, ReductionPythonRefInfo)
Expand Down Expand Up @@ -2838,6 +2839,7 @@ def test_strided_layout(self, device, dtype, op):
strided_result = op(sample.input, *sample.args, **kwargs)
self.assertEqual(strided_result.layout, torch.strided)


print("Updating MPS")
mps_op_db(op_db)
print("Updated MPS")
Expand Down
Loading
0