Add torch.cat tensors type promotion description #141339
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141339
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 59428ff with merge base dbe4b69 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@albanD please review the change when available, thanks! |
torch/_torch_docs.py
Outdated
| .. note:: It is recommended to keep all `tensors` in the same dtype to avoid unintended type promotion. | ||
| For example, mixing `torch.int32` and `torch.int64` may result in the output being automatically | ||
| promoted to `torch.int64`. |
There was a problem hiding this comment.
I'm not sure this is needed. All functions in PyTorch have this behavior of doing type promotion.
If you think it is necessary to leave a comment here, you can make it one sentence and make it not a "may" but "will"
There was a problem hiding this comment.
If it's a common sense, I think unnecessary to declare this behavior in the method, removed!
Thanks!
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
|
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
|
Successfully rebased |
301fa6f to
59428ff
Compare
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 3 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
|
@pytorchbot merge I had to trigger the CI again before the merge could happen! |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Fixes #126964
Add note description about type promotion of
torch.catTest Result
Before
After
cc @albanD @svekars