Support torch.Event elapsed_time method on XPU #140865
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140865
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 4644add with merge base 9e299b8 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Samkm0084
approved these changes
Nov 16, 2024
|
@pytorchbot rebase -b main |
|
@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here |
|
Successfully rebased |
|
@gujinghui @EikanWang May I know if you could help review this PR? |
|
Rebased |
gujinghui
approved these changes
Nov 27, 2024
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 28, 2024
# Motivation This PR intends to reland #134666 that has been reverted in #140872 We reverted it because I forgot to support `elapsed_time` for `XPUGuardImpl`, which resulted in `c10::Event` not supporting' elapsed_time' and blocking XPU CI. # Additional Context We split #134666 into two parts: one part, PR #140865, supports `elapsed_time` for `torch.Event` and another one, this PR, supports for `torch.xpu.elapsed_time`. Pull Request resolved: #140873 Approved by: https://github.com/gujinghui ghstack dependencies: #140865
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 3, 2024
# Motivation Fix this UT failure introduced by #140865. The unrelated failure suppressed this UT failure. It goes to happen since #141546 is landed. Pull Request resolved: #141800 Approved by: https://github.com/EikanWang
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
# Motivation This PR aims to support c10::Event/torch.Event elapsed_time method on XPU. We create a profiling tag Event when the timing flag is enabled. Pull Request resolved: pytorch#140865 Approved by: https://github.com/Samkm0084, https://github.com/gujinghui
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
# Motivation This PR intends to reland pytorch#134666 that has been reverted in pytorch#140872 We reverted it because I forgot to support `elapsed_time` for `XPUGuardImpl`, which resulted in `c10::Event` not supporting' elapsed_time' and blocking XPU CI. # Additional Context We split pytorch#134666 into two parts: one part, PR pytorch#140865, supports `elapsed_time` for `torch.Event` and another one, this PR, supports for `torch.xpu.elapsed_time`. Pull Request resolved: pytorch#140873 Approved by: https://github.com/gujinghui ghstack dependencies: pytorch#140865
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
# Motivation Fix this UT failure introduced by pytorch#140865. The unrelated failure suppressed this UT failure. It goes to happen since pytorch#141546 is landed. Pull Request resolved: pytorch#141800 Approved by: https://github.com/EikanWang
73 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Motivation
This PR aims to support c10::Event/torch.Event elapsed_time method on XPU. We create a profiling tag Event when the timing flag is enabled.
cc @gujinghui @EikanWang @fengyuan14