10000 [AOTI XPU] Add XPUStreamGuard for XPU which is necessary for AOTI. by etaf · Pull Request #140819 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[AOTI XPU] Add XPUStreamGuard for XPU which is necessary for AOTI. #140819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[AOTI XPU] Add XPUStreamGuard for XPU which is necessary for AOTI. #140819

wants to merge 4 commits into from

Conversation

etaf
Copy link
Collaborator
@etaf etaf commented Nov 15, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

This PR created XPUStreamGuard instead of reuse StreamGuard for the following reason:

  1. it can be profitable to replace some interfaces with refined types (e.g., return XPUStream instead of Stream) https://github.com/pytorch/pytorch/blob/e2e67a010ac359899e24cebcbd04337831d10b9b/c10/core/DeviceGuard.h#L188C1-L200C53
  2. XPUStreamGuard/CudaStreamGuard set the guarded stream as current stream which is necessary in AOTI, but StreamGuard not

@etaf
Update
7e643dc 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Nov 15, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140819

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit d6f5273 with merge base e2e67a0 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Nov 15, 2024
Closed
Closed
Closed
Closed
Closed
@etaf etaf requested review from desertfire and jansel November 16, 2024 02:11
@etaf etaf added the topic: not user facing topic category label Nov 16, 2024
@etaf
Update
4a38cde 
[ghstack-poisoned]
etaf added 2 commits November 20, 2024 08:46
@etaf
Update
90a5a19 
[ghstack-poisoned]
@etaf
Update
d6f5273 
[ghstack-poisoned]
guangyey
guangyey requested changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator
@guangyey guangyey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't introduce XPUStreamGuard. Use c10::StreamGuard instead.

@etaf
Copy link
Collaborator Author
etaf commented Nov 21, 2024

Please don't introduce XPUStreamGuard. Use c10::StreamGuard instead.

Can you check the PR description?

@guangyey
Copy link
Collaborator

Can you check the PR description?

it can be profitable to replace some interfaces with refined types (e.g., return XPUStream instead of Stream

You can use c10::Stream to construct XPUStream.

XPUStreamGuard/CudaStreamGuard set the guarded stream as current stream which is necessary in AOTI, but StreamGuard not

No, StreamGuard has the same functionality.

@etaf etaf closed this Nov 23, 2024
Esquains pushed a commit to Esquains/study1 that referenced this pull request Dec 15, 2024
@etaf
[AOTI XPU] Add XPUStreamGuard for XPU which is necessary for AOTI.
1b5b437 
ghstack-source-id: 0a57bda
Pull Request resolved: pytorch/pytorch#140819
@github-actions github-actions bot deleted the gh/etaf/66/head branch December 24, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guangyey guangyey guangyey requested changes

@desertfire desertfire desertfire approved these changes

@EikanWang EikanWang Awaiting requested review from EikanWang

@gujinghui gujinghui Awaiting requested review from gujinghui

@jansel jansel Awaiting requested review from jansel

Assignees
No one assigned
Labels
open source topic: not user facing topic category
Projects
PyTorch Intel
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@etaf @guangyey @desertfire @pytorchbot
0