8000 Add Windows Arm64 Nightly Builds by iremyux · Pull Request #139760 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Add Windows Arm64 Nightly Builds #139760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 294 commits into from
Closed

Add Windows Arm64 Nightly Builds #139760

wants to merge 294 commits into from

Conversation

iremyux
Copy link
Collaborator
@iremyux iremyux commented Nov 5, 2024 •
edited
Loading

@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Nov 5, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139760

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit 141ff01 with merge base 6cf360b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Nov 5, 2024
@iremyux iremyux added the ciflow/nightly Trigger all jobs we run nightly (nightly.yml) label Nov 5, 2024
@iremyux iremyux added ciflow/binaries Trigger all binary build and upload jobs on the PR and removed ciflow/nightly Trigger all jobs we run nightly (nightly.yml) ciflow/binaries Trigger all binary build and upload jobs on the PR labels Nov 5, 2024
@iremyux iremyux added ciflow/binaries Trigger all binary build and upload jobs on the PR and removed ciflow/binaries Trigger all binary build and upload jobs on the PR labels Nov 12, 2024
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Nov 12, 2024

Please seek CI approval before scheduling CIFlow labels

@pytorch-bot pytorch-bot bot removed the ciflow/binaries Trigger all binary build and upload jobs on the PR label Nov 12, 2024
@iremyux iremyux added the ciflow/binaries Trigger all binary build and upload jobs on the PR label Nov 12, 2024
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Nov 12, 2024

Please seek CI approval before scheduling CIFlow labels

@pytorch-bot pytorch-bot bot removed the ciflow/binaries Trigger all binary build and upload jobs on the PR label Nov 12, 2024
@seemethere
Copy link
Member

@pytorchbot label ciflow/binaries

@pytorch-bot pytorch-bot bot added the ciflow/binaries Trigger all binary build and upload jobs on the PR label Nov 12, 2024
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Nov 12, 2024

Please seek CI approval before scheduling CIFlow labels

@pytorch-bot pytorch-bot bot removed the ciflow/binaries Trigger all binary build and upload jobs on the PR label Nov 12, 2024
@seemethere seemethere mentioned this pull request Nov 12, 2024
Closed
@iremyux iremyux added the ciflow/binaries Trigger all binary build and upload jobs on the PR label Nov 13, 2024
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Nov 13, 2024

Please seek CI approval before scheduling CIFlow labels

@pytorch-bot pytorch-bot bot removed the ciflow/binaries Trigger all binary build and upload jobs on the PR label Nov 13, 2024
@iremyux iremyux added the ciflow/binaries Trigger all binary build and upload jobs on the PR label Nov 14, 2024
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Nov 14, 2024

Please seek CI approval before scheduling CIFlow labels

@pytorch-bot pytorch-bot bot removed the ciflow/binaries Trigger all binary build and upload jobs on the PR label Nov 14, 2024
seemethere
seemethere reviewed Mar 5, 2025
View reviewed changes
@iremyux iremyux added ciflow/win-arm64 Trigger Windows Arm64 CI Workflows and removed ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR labels Mar 5, 2025
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Mar 5, 2025

Warning: Unknown label ciflow/win-arm64.
Currently recognized labels are

  • ciflow/binaries
  • ciflow/binaries_libtorch
  • ciflow/binaries_wheel
  • ciflow/inductor
  • ciflow/inductor-periodic
  • ciflow/inductor-rocm
  • ciflow/inductor-perf-test-nightly-rocm
  • ciflow/inductor-perf-compare
  • ciflow/inductor-micro-benchmark
  • ciflow/inductor-micro-benchmark-cpu-x86
  • ciflow/inductor-cu126
  • ciflow/linux-aarch64
  • ciflow/mps
  • ciflow/nightly
  • ciflow/periodic
  • ciflow/rocm
  • ciflow/rocm-mi300
  • ciflow/s390
  • ciflow/slow
  • ciflow/trunk
  • ciflow/unstable
  • ciflow/xpu
  • ciflow/torchbench
  • ciflow/autoformat

Please add the new label to .github/pytorch-probot.yml

malfet
malfet reviewed Mar 5, 2025
View reviewed changes
malfet
malfet requested changes Mar 5, 2025
View reviewed changes
Copy link
Contributor
@malfet malfet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not trigger CD, on ciflow/win-arm64 labels (ciflow/binary_wheels should be sufficient)

@iremyux iremyux added ciflow/binaries Trigger all binary build and upload jobs on the PR and removed ciflow/win-arm64 Trigger Windows Arm64 CI Workflows labels Mar 6, 2025
@iremyux iremyux requested a review from malfet March 6, 2025 12:51
@iremyux
Copy link
Collaborator Author
iremyux commented Mar 6, 2025

@malfet @seemethere
All of the reviews are addressed and resolved, can you please take a look again?

@malfet malfet mentioned this pull request Mar 7, 2025
Closed
malfet
malfet approved these changes Mar 7, 2025
View reviewed changes
Copy link
Contributor
@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm filing a followup task to #148776 and propose to revert this PR if this is not closed within next say 30 days

@malfet
Copy link
Contributor
malfet commented Mar 7, 2025

@pytorchbot merge -f "Sure, let's see how it will work, but I'm confused why its only Python-3.12 now"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@iremyux iremyux deleted the nightly-for-win-arm64 branch March 21, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blackhex Blackhex Blackhex left review comments

@huydhn huydhn huydhn left review comments

@seemethere seemethere seemethere left review comments

@atalman atalman atalman left review comments

@ozanMSFT ozanMSFT ozanMSFT left review comments

@malfet malfet malfet approved these changes

Assignees
No one assigned
Labels
ciflow/binaries Trigger all binary build and upload jobs on the PR Merged open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@iremyux @seemethere @ozanMSFT @malfet @pytorchmergebot @Blackhex @huydhn @atalman @pytorchbot @janeyx99
0