8000 turn off USE_MIMALLOC_ON_MKL temporary. by xuhancn · Pull Request #139204 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content
/ pytorch Public

turn off USE_MIMALLOC_ON_MKL temporary. #139204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

turn off USE_MIMALLOC_ON_MKL temporary. #139204

wants to merge 1 commit into from

Conversation

xuhancn
Copy link
Collaborator
@xuhancn xuhancn commented Oct 29, 2024 •
edited
Loading

Fixes #138994

We can turn off USE_MIMALLOC_ON_MKL temporary. Due to it caused #138994

For totally fixed, we need fix USE_STATIC_MKL lost functionality issue: #138996, and then get the correctly MKL linking type(shared/static). It still need some time to pass all CI and builder scripts.

cc @peterjc123 @mszhanyi @skyline75489 @nbcsm @iremyux @Blackhex @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10

@xuhancn xuhancn added module: windows Windows support for PyTorch module: mkl Related to our MKL support topic: not user facing topic category intel This tag is for PR from Intel labels Oct 29, 2024
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Oct 29, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139204

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f5fc783 with merge base d8f99f3 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@xuhancn xuhancn added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 29, 2024
@xuhancn xuhancn requested a review from ezyang October 29, 2024 16:55
@mikaylagawarecki mikaylagawarecki added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 30, 2024
@ezyang
Copy link
Contributor
ezyang commented Oct 30, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@xuhancn xuhancn deleted the xu_turn_off_USE_MIMALLOC_ON_MKL branch October 31, 2024 03:30
@xuhancn xuhancn mentioned this pull request Oct 31, 2024
Closed
rahulsingh-intel pushed a commit to rahulsingh-intel/pytorch that referenced this pull request Nov 5, 2024
@xuhancn @rahulsingh-intel
turn off USE_MIMALLOC_ON_MKL temporary. (pytorch#139204)
9c925ae 
Fixes pytorch#138994

We can turn off `USE_MIMALLOC_ON_MKL` temporary. Due to it caused pytorch#138994

For totally fixed, we need fix `USE_STATIC_MKL` lost functionality issue: pytorch#138996, and then get the correctly MKL linking type(shared/static). It still need some time to pass all CI and builder scripts.

Pull Request resolved: pytorch#139204
Approved by: https://github.com/ezyang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezyang ezyang ezyang approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request intel This tag is for PR from Intel Merged module: mkl Related to our MKL support module: windows Windows support for PyTorch open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build failed when use shared MKL library
5 participants
@xuhancn @ezyang @pytorchmergebot @pytorchbot @mikaylagawarecki
0