[Windows XPU] Fix MSVC ambiguous symbol error #138727
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138727
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 31a8915 with merge base bf1b8ad ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
|
Successfully rebased |
8774cdd to
2e5b121
Compare
|
@pytorchbot rebase -b main |
|
@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here |
|
Successfully rebased |
2e5b121 to
bc1708e
Compare
|
@ratnampa , pls. fix the lint issue ASAP. |
|
Done |
|
@pytorchbot rebase -b main |
|
@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here |
|
Successfully rebased |
2678511 to
873a307
Compare
| @@ -1044,6 +1044,9 @@ if(USE_XPU) | |||
| add_library(torch_xpu ${Caffe2_XPU_SRCS}) | |||
| torch_compile_options(torch_xpu) # see cmake/public/utils.cmake | |||
| target_compile_definitions(torch_xpu PRIVATE USE_XPU) | |||
| if(WIN32) | |||
| target_compile_options(torch_xpu PRIVATE /permissive-) | |||
There was a problem hiding this comment.
We added the option /permissive- to ask the compiler to disable permissive behaviors and execute strict conformance to avoid ambiguous symbol error on Windows. Please refer to /permissive- for more details.
|
seems like it failing tho |
|
@pytorchbot rebase -b main |
|
@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here |
|
Successfully rebased |
873a307 to
31a8915
Compare
Thanks, the failure is related to #140095, introduced by inductor UT and irrelevant to this PR. |
|
"failure is related to Linux inductor UT, irrelevant to this PR" |
Merge startedYour change will be merged while ignoring the following 2 checks: xpu / linux-jammy-xpu-py3.9 / test (default, 1, 4, linux.idc.xpu), xpu / linux-jammy-xpu-py3.9 / test (default, 2, 4, linux.idc.xpu) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
PT master build with XPU will fail due to MSVC issue of ambiguous symbol error 'std', previously fixed it with MSVC flag in torch-xpu-ops https://github.com/intel/torch-xpu-ops/pull/946/files, but the error is observed in PT master too after 2.5 and oneAPI update. Pull Request resolved: #138727 Approved by: https://github.com/guangyey, https://github.com/ezyang
PT master build with XPU will fail due to MSVC issue of ambiguous symbol error 'std', previously fixed it with MSVC flag in torch-xpu-ops https://github.com/intel/torch-xpu-ops/pull/946/files, but the error is observed in PT master too after 2.5 and oneAPI update. Pull Request resolved: pytorch#138727 Approved by: https://github.com/guangyey, https://github.com/ezyang
PT master build with XPU will fail due to MSVC issue of ambiguous symbol error 'std', previously fixed it with MSVC flag in torch-xpu-ops https://github.com/intel/torch-xpu-ops/pull/946/files, but the error is observed in PT master too after 2.5 and oneAPI update. Pull Request resolved: pytorch#138727 Approved by: https://github.com/guangyey, https://github.com/ezyang
PT master build with XPU will fail due to MSVC issue of ambiguous symbol error 'std', previously fixed it with MSVC flag in torch-xpu-ops https://github.com/intel/torch-xpu-ops/pull/946/files, but the error is observed in PT master too after 2.5 and oneAPI update. Pull Request resolved: pytorch#138727 Approved by: https://github.com/guangyey, https://github.com/ezyang
PT master build with XPU will fail due to MSVC issue of ambiguous symbol error 'std', previously fixed it with MSVC flag in torch-xpu-ops https://github.com/intel/torch-xpu-ops/pull/946/files, but the error is observed in PT master too after 2.5 and oneAPI update. Pull Request resolved: pytorch#138727 Approved by: https://github.com/guangyey, https://github.com/ezyang
PT master build with XPU will fail due to MSVC issue of ambiguous symbol error 'std', previously fixed it with MSVC flag in torch-xpu-ops https://github.com/intel/torch-xpu-ops/pull/946/files, but the error is observed in PT master too after 2.5 and oneAPI update.