10000 [ts converter] use Dim.AUTO for ts -> export converter by pianpwk · Pull Request #138273 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[ts converter] use Dim.AUTO for ts -> export converter #138273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[ts converter] use Dim.AUTO for ts -> export converter #138273

wants to merge 1 commit into from

Conversation

pianpwk
Copy link
Contributor
@pianpwk pianpwk commented Oct 17, 2024 •
edited
Loading

Switches TS converter to use Dim.AUTO by default, exporting models with max dynamism. Adds runtime input tests to test_converter.py

< 8000 div class="js-timeline-item js-timeline-progressive-focus-container" data-gid="IC_kwDOA-j9z86QST0o">
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Oct 17, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138273

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b27ab2b with merge base a7ba562 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pianpwk pianpwk marked this pull request as ready for review October 17, 2024 22:19
@facebook-github-bot
Copy link
Contributor

@pianpwk has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@github-actions GitHub Actions
Copy link
Contributor

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a main 10000 tainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Dec 17, 2024
facebook-github-bot pushed a commit that referenced this pull request Dec 18, 2024
@pianpwk @facebook-github-bot
[ts converter] use Dim.AUTO for ts -> export converter (#138273)
97ed305 
Summary:
Switches TS converter to use `Dim.AUTO` by default, adding runtime input tests to `test_converter.py`


Differential Revision: D64568000

Pulled By: pianpwk
@facebook-github-bot facebook-github-bot force-pushed the pianpwk/ts_converter_dim_auto branch from cc22634 to 97ed305 Compare December 18, 2024 04:25
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64568000

@pianpwk @facebook-github-bot
[ts converter] use Dim.AUTO for ts -> export converter (#138273)
b27ab2b 
Summary:
Switches TS converter to use `Dim.AUTO` by default, exporting models with max dynamism. Adds runtime input tests to `test_converter.py`


Differential Revision: D64568000

Pulled By: pianpwk
@facebook-github-bot facebook-github-bot force-pushed the pianpwk/ts_converter_dim_auto branch from 97ed305 to b27ab2b Compare December 19, 2024 06:01
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64568000

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 20, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about 8000 merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the pianpwk/ts_converter_dim_auto branch January 20, 2025 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avikchaudhuri avikchaudhuri avikchaudhuri approved these changes

@tugsbayasgalan tugsbayasgalan Awaiting requested review from tugsbayasgalan tugsbayasgalan is a code owner

@zhxchen17 zhxchen17 Awaiting requested review from zhxchen17 zhxchen17 is a code owner

@ydwu4 ydwu4 Awaiting requested review from ydwu4 ydwu4 is a code owner

@angelayi angelayi Awaiting requested review from angelayi angelayi is a code owner

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged release notes: export Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pianpwk @facebook-github-bot @pytorchmergebot @avikchaudhuri
0