8000 Bump optree version to 0.13.0 to enable Python 3.13 and Python 3.13t support by XuehaiPan · Pull Request #137396 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Bump optree version to 0.13.0 to enable Python 3.13 and Python 3.13t support #137396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Bump optree version to 0.13.0 to enable Python 3.13 and Python 3.13t support #137396

wants to merge 3 commits into from

Conversation

XuehaiPan
Copy link
Collaborator
@XuehaiPan XuehaiPan commented Oct 5, 2024 •
edited
Loading

@XuehaiPan
Update
94a885f 
[ghstack-poisoned]
@XuehaiPan XuehaiPan requested review from a team and jeffdaily as code owners October 5, 2024 11:44
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Oct 5, 2024
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Oct 5, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137396

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 4db48a0 with merge base 1dc1b85 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Oct 4, 2024
Closed
Closed
Closed
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Oct 5, 2024
@XuehaiPan
Bump optree version to 0.13.0 to enable Python 3.13 and Python 3.13t …
9d8c7fc 
…support

ghstack-source-id: d45ddfc
Pull Request resolved: pytorch#137396
@XuehaiPan XuehaiPan added ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/trunk Trigger trunk jobs on your pull request labels Oct 5, 2024
@XuehaiPan XuehaiPan requested a review from albanD October 5, 2024 11:52
@XuehaiPan XuehaiPan requested a review from zou3519 October 5, 2024 11:53
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Oct 5, 2024
@XuehaiPan
Bump optree version to 0.13.0 to enable Python 3.13 and Python 3.13t …
ad4fd48 
…support

ghstack-source-id: d45ddfc
Pull Request resolved: pytorch#137396
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Oct 5, 2024
@XuehaiPan
Bump optree version to 0.13.0 to enable Python 3.13 and Python 3.13t …
1e13de5 
…support

ghstack-source-id: d45ddfc
Pull Request resolved: pytorch#137396
This was referenced Oct 5, 2024
Closed
Open
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Oct 5, 2024
@XuehaiPan
Bump optree version to 0.13.0 to enable Python 3.13 and Python 3.13t …
ebe899e 
…support

ghstack-source-id: d45ddfc
Pull Request resolved: pytorch#137396
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Oct 5, 2024
@XuehaiPan
Bump optree version to 0.13.0 to enable Python 3.13 and Python 3.13t …
478642d 
…support

ghstack-source-id: d45ddfc
Pull Request resolved: pytorch#137396
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Oct 5, 2024
@XuehaiPan
Bump optree version to 0.13.0 to enable Python 3.13 and Python 3.13t …
de2c4bc 
…support

ghstack-source-id: d45ddfc
Pull Request resolved: pytorch#137396
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Oct 5, 2024
@XuehaiPan
Bump optree version to 0.13.0 to enable Python 3.13 and Python 3.13t …
91701f5 
…support

ghstack-source-id: d45ddfc
Pull Request resolved: pytorch#137396
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Oct 5, 2024
@XuehaiPan
Bump optree version to 0.13.0 to enable Python 3.13 and Python 3.13t …
4417de2 
…support

ghstack-source-id: d45ddfc
Pull Request resolved: pytorch#137396
@XuehaiPan
Update
78cac89 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Oct 6, 2024
@XuehaiPan
Bump optree version to 0.13.0 to enable Python 3.13 and Python 3.13t …
29ca095 
…support

ghstack-source-id: d45ddfc
Pull Request resolved: pytorch#137396
@XuehaiPan XuehaiPan mentioned this pull request Oct 6, 2024
Closed
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Oct 6, 2024
@XuehaiPan
Bump optree version to 0.13.0 to enable Python 3.13 and Python 3.13t …
4eaf10b 
…support

ghstack-source-id: 86acf97
Pull Request resolved: pytorch#137396
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Oct 6, 2024
@XuehaiPan
Bump optree version to 0.13.0 to enable Python 3.13 and Python 3.13t …
a10e133 
…support

ghstack-source-id: 86acf97
Pull Request resolved: pytorch#137396
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Oct 6, 2024
@XuehaiPan
Bump optree version to 0.13.0 to enable Python 3.13 and Python 3.13t …
e18eef6 
…support

ghstack-source-id: 86acf97
Pull Request resolved: pytorch#137396
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Oct 6, 2024
@XuehaiPan
Bump optree version to 0.13.0 to enable Python 3.13 and Python 3.13t …
e32f755 
…support

ghstack-source-id: 86acf97
Pull Request resolved: pytorch#137396
@XuehaiPan
Update
4db48a0 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Oct 6, 2024
@XuehaiPan
Bump optree version to 0.13.0 to enable Python 3.13 and Python 3.13t …
d446a9a 
…support

ghstack-source-id: 54284c0
Pull Request resolved: pytorch#137396
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Oct 6, 2024
@XuehaiPan
Bump optree version to 0.13.0 to enable Python 3.13 and Python 3.13t …
26fd5ad 
…support

ghstack-source-id: 54284c0
Pull Request resolved: pytorch#137396
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Oct 6, 2024
@XuehaiPan
Bump optree version to 0.13.0 to enable Python 3.13 and Python 3.13t …
fe77b84 
…support

ghstack-source-id: 54284c0
Pull Request resolved: pytorch#137396
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Oct 6, 2024
@XuehaiPan
Bump optree version to 0.13.0 to enable Python 3.13 and Python 3.13t …
fb9f39c 
…support

ghstack-source-id: 54284c0
Pull Request resolved: pytorch#137396
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Oct 7, 2024
@XuehaiPan
Bump optree version to 0.13.0 to enable Python 3.13 and Python 3.13t …
3df5c19 
…support

ghstack-source-id: 54284c0
Pull Request resolved: pytorch#137396
albanD
albanD approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator
@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@albanD
Copy link
Collaborator
albanD commented Oct 7, 2024

And I can confirm that this upgrade fixes the following error for me locally

Debug memory block at address p=0x7fa0b43f2d00: API 'o'
    38 bytes originally requested
    The 7 pad bytes at p-7 are FORBIDDENBYTE, as
8000
 expected.
    The 8 pad bytes at tail=0x7fa0b43f2d26 are FORBIDDENBYTE, as expected.
    Data at p: 49 74 65 72 61 74 6f 72 ... 70 79 74 72 65 65 2e 00

Enable tracemalloc to get the memory block allocation traceback

Fatal Python error: _PyMem_DebugRawFree: bad ID: Allocated using API 'o', verified using API 'm'
Python runtime state: finalizing (tstate=0x0000000000999558)

Current thread 0x00007fa198de0740 (most recent call first):
  Garbage-collecting
  <no Python frame>
Aborted (core dumped)

(most likely due to the older pybind11 used in the older optree versions)

@XuehaiPan
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 3 jobs have failed, first few of them are: windows-binary-conda / conda-py3_10-cuda11_8-test, windows-binary-conda / conda-py3_9-cuda11_8-test, windows-binary-wheel / wheel-py3_12-cpu-test

Details for Dev Infra team Raised by workflow job

@XuehaiPan
Copy link
Collaborator Author

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 0 checks:

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@XuehaiPan
Copy link
Collaborator Author

@pytorchbot merge -f "stuck at Windows CI queue"

@pytorchmergebot
Copy link
Collaborator
pytorchmergebot commen 6D47 ted Oct 8, 2024

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@XuehaiPan
Copy link
Collaborator Author

@pytorchbot merge -f "stuck at Windows CI queue"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@XuehaiPan XuehaiPan mentioned this pull request Oct 8, 2024
Closed
9 tasks
@github-actions github-actions bot deleted the gh/XuehaiPan/175/head branch November 8, 2024 02:06
@malfet malfet mentioned this pull request Apr 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albanD albanD albanD approved these changes

@jeffdaily jeffdaily Awaiting requested review from jeffdaily

@zou3519 zou3519 Awaiting requested review from zou3519

Assignees
No one assigned
Labels
ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged module: pytree open source topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XuehaiPan @albanD @pytorchmergebot @pytorchbot
0