8000 Implement HPUHooksInterface by bsochack · Pull Request #137394 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Implement HPUHooksInterface #137394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Implement HPUHooksInterface #137394

wants to merge 5 commits into from

Conversation

bsochack
Copy link
@bsochack bsochack commented Oct 5, 2024

Fixes regression #137262

@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Oct 5, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137394

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 1195682 with merge base b7eb725 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@bsochack
Copy link
Author
bsochack commented Oct 5, 2024

@atalman, @kit1980, @albanD, please help to review the change. It fixes the regression after interface changes for Intel Gaudi accelerator

@bsochack bsochack mentioned this pull request Oct 5, 2024
Closed
@kit1980 kit1980 added this to the 2.5.1 milestone Oct 5, 2024
@cyyever cyyever requested a review from albanD October 6, 2024 10:57
@bsochack
Copy link
Author
bsochack commented Oct 7, 2024

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Oct 7, 2024
@kit1980 kit1980 closed this Oct 11, 2024
@kit1980
Copy link
< 8000 /details>
Contributor
kit1980 commented Oct 11, 2024

Closing this for 2.5.0.

@kit1980 kit1980 removed this from the 2.5.1 milestone Oct 11, 2024
@bsochack
Copy link
Author
bsochack commented Oct 11, 2024 •
edited
Loading

@kit1980 why was it closed? The discussion was to merge it to 2.5.1

@kit1980 kit1980 reopened this Oct 11, 2024
@kit1980
Copy link
Contributor
kit1980 commented Oct 11, 2024

I've re-opened.
I forgot that 2.5.0 has the same branch as 2.5.1.

@kit1980 kit1980 added this to the 2.5.1 milestone Oct 11, 2024
@bsochack
Copy link
Author

@kit1980 can this change be merged to 2.5 branch ?

@kit1980
Copy link
Contributor
kit1980 commented Oct 22, 2024

@bsochack Not now. We are going to do one-issue fix for 2.5.1.

@kit1980
Copy link
Contributor
kit1980 commented Oct 23, 2024

2.5.1 is an emergency patch release to address specific large regressions, moving this to 2.6.0

@kit1980 kit1980 modified the milestones: 2.5.1, 2.6.0 Oct 23, 2024
@kit1980 kit1980 closed this Oct 23, 2024
@bsochack
Copy link
Author

@kit1980 the changes broke Intel Gaudi support. This patch is low risk for other devices. We really would like to see it in PT 2.5.1

@kit1980
Copy link
Contributor
kit1980 commented Oct 23, 2024 •
edited
Loading

@bsochack Sorry, we don't have time for 2.5.1. Especially taken into account that even the change to main is not landed.
It's possible we will be doing 2.5.2.

@malfet
Copy link
Contributor
malfet commented Oct 23, 2024

In general, we should auto-close all cherry-picks into release branch if there are no corresponding commit to trunk PR of if has not been landed for some reason. When it's landed on trunk, we can restart the discussion

@bsochack
Copy link
Author

@kit1980 @malfet the unfortunate thing about main is that this functionality was re-written again.
The patches listed here #136519 are merged and reverted multiple times, causing merge conflicts etc. It is fine, but it blocks merge of the change to main and the change to main had to be refactored.

@atalman atalman mentioned this pull request Jan 13, 2025
Closed
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albanD albanD Awaiting requested review from albanD

Assignees
No one assigned
Labels
open source topic: not user facing topic category
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@bsochack @kit1980 @malfet @pytorchbot @tbohutyn
0