[Environment Variable][3/N] Use thread-safe getenv wrapper #137328
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137328
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 96d5575 with merge base 8486d3d ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
621e02d to
9f65055
Compare
|
These things are only thread-safe if all the calls are under the same lock and that's not likely to be the case. For example, uses of the |
|
Of course, these functions should be applied consistently across the whole code base to achieve the effects. |
|
@eqy Fixed incorrect rebase. |
|
@pytorchmergebot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchmergebot merge -f "Passed before conflict" |
|
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -m "need to revert this in order to revert #133896, please rebase and reland, sorry for the churn" -c weird |
|
@pytorchbot successfully started a revert job. Check the current status here. |
|
@cyyever your PR has been successfully reverted. |
…137328)" This reverts commit 25ac565. Reverted #137328 on behalf of https://github.com/clee2000 due to need to revert this in order to revert #133896, please rebase and reland, sorry for the churn ([comment](#137328 (comment)))
…137942) Reland of #137328, which was reverted due to reverting a dependent PR. Pull Request resolved: #137942 Approved by: https://github.com/eqy
Follows #124485 Pull Request resolved: #137328 Approved by: https://github.com/eqy
…137328)" This reverts commit 25ac565. Reverted #137328 on behalf of https://github.com/clee2000 due to need to revert this in order to revert #133896, please rebase and reland, sorry for the churn ([comment](#137328 (comment)))
…137942) Reland of #137328, which was reverted due to reverting a dependent PR. Pull Request resolved: #137942 Approved by: https://github.com/eqy
Follows #137328 Pull Request resolved: #137843 Approved by: https://github.com/ezyang
Follows #137328 Pull Request resolved: #137843 Approved by: https://github.com/ezyang
Follows #124485
cc @XilunWu @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o