[Doc] Fix rendering of the unicode characters #134597
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#124771 introduced unicode escape sequences inside raw strings, which were not renderred correctly. Fix it by relying on [string literal concatenation](https://docs.python.org/3/reference/lexical_analysis.html#string-literal-concatenation) to join raw and regular strings together during lexical analysis stage Fixes #134422
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/134597
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 7c0ea6a with merge base 0a3c064 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
aorenste
approved these changes
Aug 27, 2024
Skylion007
approved these changes
Aug 27, 2024
|
@pytorchbot merge -f "Lint and docs are looking good" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot cherry-pick --onto release/2.4 -c doc |
|
❌ 🤖 pytorchbot command failed: Try |
|
@pytorchbot cherry-pick --onto release/2.4 -c docs |
pytorchbot
pushed a commit
that referenced
this pull request
Aug 28, 2024
#124771 introduced unicode escape sequences inside raw strings, which were not rendered correctly. Also fix typo in `\uue0 ` escape sequence (should have been `\u00e0`) Fix it by relying on [string literal concatenation](https://docs.python.org/3/reference/lexical_analysis.html#string-literal-concatenation) to join raw and regular strings together during lexical analysis stage Fixes #134422 Pull Request resolved: #134597 Approved by: https://github.com/aorenste, https://github.com/Skylion007 (cherry picked from commit 534f43d)
Cherry picking #134597The cherry pick PR is at #134695 The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
malfet
added a commit
that referenced
this pull request
Aug 29, 2024
* [Doc] Fix rendering of the unicode characters (#134597) #124771 introduced unicode escape sequences inside raw strings, which were not rendered correctly. Also fix typo in `\uue0 ` escape sequence (should have been `\u00e0`) Fix it by relying on [string literal concatenation](https://docs.python.org/3/reference/lexical_analysis.html#string-literal-concatenation) to join raw and regular strings together during lexical analysis stage Fixes #134422 Pull Request resolved: #134597 Approved by: https://github.com/aorenste, https://github.com/Skylion007 (cherry picked from commit 534f43d) * Fix lint --------- Co-authored-by: Nikita Shulga <nshulga@meta.com>
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
pytorch#124771 introduced unicode escape sequences inside raw strings, which were not rendered correctly. Also fix typo in `\uue0 ` escape sequence (should have been `\u00e0`) Fix it by relying on [string literal concatenation](https://docs.python.org/3/reference/lexical_analysis.html#string-literal-concatenation) to join raw and regular strings together during lexical analysis stage Fixes pytorch#134422 Pull Request resolved: pytorch#134597 Approved by: https://github.com/aorenste, https://github.com/Skylion007
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#124771 introduced unicode escape sequences inside raw strings, which were not rendered correctly. Also fix typo in
\uue0escape sequence (should have been\u00e0)Fix it by relying on string literal concatenation to join raw and regular strings together during lexical analysis stage
Fixes #134422
cc @albanD