8000 Enable clang-tidy warnings on aten/src/ATen/cuda/*.cpp by cyyever · Pull Request #134547 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Enable clang-tidy warnings on aten/src/ATen/cuda/*.cpp #134547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Enable clang-tidy warnings on aten/src/ATen/cuda/*.cpp #134547

wants to merge 2 commits into from

Conversation

cyyever
Copy link
Collaborator
@cyyever cyyever commented Aug 27, 2024

Fixes #ISSUE_NUMBER

@cyyever cyyever requested review from eqy and syed-ahmed as code owners August 27, 2024 03:43
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Aug 27, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/134547

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6e6a00f with merge base 35532fc (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@cyyever cyyever marked this pull request as draft August 27, 2024 03:43
@cyyever cyyever added topic: not user facing topic category release notes: build release notes category labels Sep 22, 2024
@cyyever cyyever changed the title Fix clang-tidy warnings Enable clang-tidy warnings on aten/src/ATen/cuda Sep 22, 2024
@cyyever cyyever changed the title Enable clang-tidy warnings on aten/src/ATen/cuda Enable clang-tidy warnings on aten/src/ATen/cuda/*.cpp Sep 22, 2024
@cyyever cyyever requested a review from ezyang September 22, 2024 02:37
@cyyever cyyever marked this pull request as ready for review September 22, 2024 02:41
@ezyang
Copy link
Contributor
ezyang commented Sep 23, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 23, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever cyyever deleted the aten_cuda_lint2 branch September 23, 2024 09:56
BoyuanFeng pushed a commit to BoyuanFeng/pytorch that referenced this pull request Sep 25, 2024
@cyyever @BoyuanFeng
Enable clang-tidy warnings on aten/src/ATen/cuda/*.cpp (pytorch#134547)
1b86a21 
Fixes #ISSUE_NUMBER

Pull Request resolved: pytorch#134547
Approved by: https://github.com/ezyang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezyang ezyang ezyang approved these changes

@eqy eqy Awaiting requested review from eqy eqy is a code owner

@syed-ahmed syed-ahmed Awaiting requested review from syed-ahmed syed-ahmed is a code owner

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: build release notes category topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cyyever @ezyang @pytorchmergebot @pytorchbot
0