8000 [CpuInductor] Enable NEON ISA detection on Linux ARM by kit1980 · Pull Request #134165 · pytorch/pytorch · GitHub
[go: up one dir, main page]

Skip to content

[CpuInductor] Enable NEON ISA detection on Linux ARM #134165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 21, 2024
Merged

[CpuInductor] Enable NEON ISA detection on Linux ARM #134165

merged 2 commits into from
Aug 21, 2024

Conversation

kit1980
Copy link
Contributor
@kit1980 kit1980 commented Aug 21, 2024

Also, cleanup code a bit to use x in [y, z] instead of x == y or x == z

And do not redefine at_align, but instead use alignas(64) as was suggested in https://github.com/pytorch/pytorch/pull/128686/files#r1639365978

Test plan: python3 -c "import torch._inductor.codecache as cc; isa = cc.valid_vec_isa_list()[0];print(str(isa), bool(isa))"

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang

malfet and others added 2 commits August 21, 2024 12:59
Also, cleanup code a bit to use `x in [y, z]` instead of `x == y or x == z`

And do not redefine `at_align`, but instead use `alignas(64)` as was suggested in https://github.com/pytorch/pytorch/pull/128686/files#r1639365978

Test plan: `python3 -c "import torch._inductor.codecache as cc; isa = cc.valid_vec_isa_list()[0];print(str(isa), bool(isa))"`

Pull Request resolved: #129075
Approved by: https://github.com/jansel
Copy link
pytorch-bot bot commented Aug 21, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/134165

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 50 Cancelled Jobs, 102 Unrelated Failures

As of commit 9cb6f3e with merge base b66e3f0 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@malfet malfet merged commit 2213c07 into pytorch:release/2.4 Aug 21, 2024
191 of 416 checks passed
atalman added a commit to atalman/pytorch that referenced this pull request Aug 22, 2024
@kit1980 kit1980 deleted the release/2.4 branch December 12, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0