8000 Cherry-Picking don't resolve conflicts by atalman · Pull Request #134047 · pytorch/pytorch · GitHub
[go: up one dir, main page]

Skip to content

Cherry-Picking don't resolve conflicts #134047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

atalman
Copy link
Contributor
@atalman atalman commented Aug 20, 2024

During cherry-picking we want to use default setting and fail if there is merge conflict
Here an example of invalid conflict resolution:
#131194
and cherry-pick
#133590

@atalman atalman requested a review from a team as a code owner August 20, 2024 20:54
Copy link
pytorch-bot bot commented Aug 20, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/134047

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 9560542 with merge base bb0bf09 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Aug 20, 2024
@atalman
Copy link
Contributor Author
atalman commented Aug 20, 2024

@pytorchmergebot merge -f "lint is green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorch-bot bot pushed a commit that referenced this pull request Sep 13, 2024
During cherry-picking we want to use default setting and fail if there is merge conflict
Here an example of invalid conflict resolution:
#131194
and cherry-pick
#133590

Pull Request resolved: #134047
Approved by: https://github.com/kit1980
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0