10000 [BE]: Update mypy to 1.11.2 by Skylion007 · Pull Request #133816 · pytorch/pytorch · GitHub
[go: up one dir, main page]

Skip to content

[BE]: Update mypy to 1.11.2 #133816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 21 commits into from

Conversation

Skylion007
Copy link
Collaborator
@Skylion007 Skylion007 commented Aug 18, 2024

@Skylion007 Skylion007 requested a review from jeffdaily as a code owner August 18, 2024 14:40
Copy link
pytorch-bot bot commented Aug 18, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/133816

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit f51cf3b with merge base 8c738c9 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Aug 18, 2024
@Skylion007 Skylion007 added the better-engineering Relatively self-contained tasks for better engineering contributors label Aug 18, 2024
@Skylion007 Skylion007 requested review from ezyang, malfet and albanD August 18, 2024 14:40
Copy link
Contributor
@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good luck fixing the wobbles!

@pytorch-bot pytorch-bot bot added ciflow/inductor module: inductor oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: quantization release notes category labels Aug 18, 2024
@Skylion007 Skylion007 force-pushed the skylion007/update-mypy-1-11 branch 2 times, most recently from 45fcd04 to ac400f9 Compare August 18, 2024 15:54
@Skylion007 Skylion007 force-pushed the skylion007/update-mypy-1-11 branch 2 times, most recently from d8d20b0 to 89e9d61 Compare August 18, 2024 19:20
@Skylion007 Skylion007 force-pushed the skylion007/update-mypy-1-11 branch 3 times, most recently from 71aa102 to dba9f19 Compare September 11, 2024 16:35
@Skylion007 Skylion007 force-pushed the skylion007/update-mypy-1-11 branch from dba9f19 to 66a6f50 Compare September 11, 2024 16:38
@Skylion007
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@Skylion007
Copy link
Collaborator Author
Skylion007 8000 commented Sep 16, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@Skylion007
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: New commits were pushed while merging. Please rerun the merge command.

Details for Dev Infra team Raised by workflow job

@Skylion007
Copy link
Collaborator Author

@pytorchbot merge

@clee2000 clee2000 added ci-no-td Do not run TD on this PR and removed merging labels Sep 16, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

You 10000 r change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@Skylion007
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

facebook-github-bot pushed a commit to pytorch/benchmark that referenced this pull request Sep 17, 2024
Summary:
Updates mypy to 1.11.1 to improve type inference

X-link: pytorch/pytorch#133816
Approved by: https://github.com/ezyang

Reviewed By: jeanschmidt

Differential Revision: D62873245

fbshipit-source-id: 4c3e2f3166b2e63ef41405b0368cf8f3af4fe0f3
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
Updates mypy to 1.11.1 to improve type inference

Pull Request resolved: pytorch#133816
Approved by: https://github.com/ezyang
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
Updates mypy to 1.11.1 to improve type inference

Pull Request resolved: pytorch#133816
Approved by: https://github.com/ezyang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
better-engineering Relatively self-contained tasks for better engineering contributors ci-no-td Do not run TD on this PR ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: cpu CPU specific problem (e.g., perf, algorithm) module: dynamo module: inductor oncall: distributed Add this issue/PR to distributed oncall triage queue open source release notes: quantization release notes category Reverted topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
0