Fix warning when pickle.load torch.Storage #133597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #130242 Since `torch.save` does not use pickle for storages, the `torch.load` in `_load_from_bytes` should not ever be called when `torch.load`-ing a checkpoint. Setting weights_only=False explicitly in `_load_from_bytes` to avoid the weights_only warning when using the pickle module Pull Request resolved: #130246 Approved by: https://github.com/albanD (cherry picked from commit dfd1d19)
This was referenced Aug 15, 2024
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/133597
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New FailuresAs of commit 6808196 with merge base b66e3f0 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
atalman
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #130242
Since
torch.savedoes not use pickle for storages, thetorch.loadin_load_from_bytesshould not ever be called whentorch.load-ing a checkpoint. Setting weights_only=False explicitly in_load_from_bytesto avoid the weights_only warning when using the pickle moduleStack from ghstack (oldest at bottom):