8000 [CpuInductor] Enable NEON ISA detection on Linux ARM by pytorchbot · Pull Request #133578 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[CpuInductor] Enable NEON ISA detection on Linux ARM #133578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[CpuInductor] Enable NEON ISA detection on Linux ARM #133578

wants to merge 1 commit into from

Conversation

pytorchbot
Copy link
Collaborator

Also, cleanup code a bit to use x in [y, z] instead of x == y or x == z

And do not redefine at_align, but instead use alignas(64) as was suggested in https://github.com/pytorch/pytorch/pull/128686/files#r1639365978

Test plan: python3 -c "import torch._inductor.codecache as cc; isa = cc.valid_vec_isa_list()[0];print(str(isa), bool(isa))"

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang

@malfet @pytorchbot
[CpuInductor] Enable NEON ISA detection on Linux ARM (#129075)
7d5b0d9 
Also, cleanup code a bit to use `x in [y, z]` instead of `x == y or x == z`

And do not redefine `at_align`, but instead use `alignas(64)` as was suggested in https://github.com/pytorch/pytorch/pull/128686/files#r1639365978

Test plan: `python3 -c "import torch._inductor.codecache as cc; isa = cc.valid_vec_isa_list()[0];print(str(isa), bool(isa))"`

Pull Request resolved: #129075
Approved by: https://github.com/jansel

(cherry picked from commit b2a9b8d)
This was referenced Aug 15, 2024
Closed
Closed
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Aug 15, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/133578

Note: Links to docs will display an error until the docs builds have been completed.

❌ 78 New Failures, 1 Unrelated Failure

As of commit 7d5b0d9 with merge base b66e3f0 (image):

NEW FAILURES - The following jobs have failed:

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@kit1980
Copy link
Contributor
kit1980 commented Aug 21, 2024

Closing as this had merge conflicts resolved incorrectly, will do another manual cherry-pick.

@kit1980 kit1980 closed this Aug 21, 2024
@github-actions github-actions bot deleted the cherry-pick-129075-by-pytorch_bot_bot_ branch September 28, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ciflow/inductor module: inductor open source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pytorchbot @kit1980 @malfet
0