Pin sympy >= 1.13.0
#130895
Closed
Pin sympy >= 1.13.0
#130895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/130895
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled JobAs of commit ef9ca93 with merge base 3c622fb ( CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
9 tasks
Closed
|
In [1]: import sympy
In [2]: f = sympy.Float(0.0)
In [3]: abs(f)
Out[3]: 0
In [4]: f == abs(f)
Out[4]: False |
|
@pytorchbot merge -i |
Merge startedYour change will be merged while ignoring the following 1 checks: Mac MPS / macos-py3-arm64-mps / test (mps, 1, 1, macos-m2-14) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Jul 20, 2024
0.12.0 Major Updates: - Add context manager to temporarily set the dictionary sorting mode - Add accessor APIs - Use `stable` tag for `pybind11` for Python 3.13 support - Fix potential segmentation fault for pickling support 0.12.1 Updates: - Fix warning regression during import when launch with strict warning filters Closes #130155 Pull Request resolved: #130139 Approved by: https://github.com/zou3519 ghstack dependencies: #130895
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jul 20, 2024
------ The opposite of pytorch#130836. Pin `sympy >= 1.13.0` for Python >= 3.9 and `sympy == 1.12.1` for Python 3.8. - pytorch#130836 See the PR description of pytorch#130836 for more details. `sympy` 1.13.0 introduces some breaking changes which break our tests. More specifically: - Ref [Backwards compatibility breaks and deprecations](https://github.com/sympy/sympy/wiki/release-notes-for-1.13.0#backwards-compatibility-breaks-and-deprecations) > BREAKING CHANGE: Float and Integer/Rational no longer compare equal with a == b. From now on Float(2.0) != Integer(2). Previously expressions involving Float would compare unequal e.g. x*2.0 != x*2 but an individual Float would compare equal to an Integer. In SymPy 1.7 a Float will always compare unequal to an Integer even if they have the same "value". Use sympy.numbers.int_valued(number) to test if a number is a concrete number with no decimal part. ([pytorch#25614](sympy/sympy#25614) by [@smichr](https://github.com/smichr)) `sympy >= 1.13.0` is required to enable Python 3.13 support. This should be part of pytorch#130689. - pytorch#130689 Pull Request resolved: pytorch#130895 Approved by: https://github.com/ezyang
This was referenced Jul 20, 2024
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jul 21, 2024
------ The opposite of pytorch#130836. Pin `sympy >= 1.13.0` for Python >= 3.9 and `sympy == 1.12.1` for Python 3.8. - pytorch#130836 See the PR description of pytorch#130836 for more details. `sympy` 1.13.0 introduces some breaking changes which break our tests. More specifically: - Ref [Backwards compatibility breaks and deprecations](https://github.com/sympy/sympy/wiki/release-notes-for-1.13.0#backwards-compatibility-breaks-and-deprecations) > BREAKING CHANGE: Float and Integer/Rational no longer compare equal with a == b. From now on Float(2.0) != Integer(2). Previously expressions involving Float would compare unequal e.g. x*2.0 != x*2 but an individual Float would compare equal to an Integer. In SymPy 1.7 a Float will always compare unequal to an Integer even if they have the same "value". Use sympy.numbers.int_valued(number) to test if a number is a concrete number with no decimal part. ([pytorch#25614](sympy/sympy#25614) by [@smichr](https://github.com/smichr)) `sympy >= 1.13.0` is required to enable Python 3.13 support. This should be part of pytorch#130689. - pytorch#130689 Pull Request resolved: pytorch#130895 Approved by: https://github.com/ezyang
pytorchmergebot
pushed a commit
that referenced
this pull request
Jul 21, 2024
Pull Request resolved: #130144 Approved by: https://github.com/zou3519 ghstack dependencies: #130895, #130139
DiweiSun
pushed a commit
to DiweiSun/pytorch
that referenced
this pull request
Jul 22, 2024
------ The opposite of pytorch#130836. Pin `sympy >= 1.13.0` for Python >= 3.9 and `sympy == 1.12.1` for Python 3.8. - pytorch#130836 See the PR description of pytorch#130836 for more details. `sympy` 1.13.0 introduces some breaking changes which break our tests. More specifically: - Ref [Backwards compatibility breaks and deprecations](https://github.com/sympy/sympy/wiki/release-notes-for-1.13.0#backwards-compatibility-breaks-and-deprecations) > BREAKING CHANGE: Float and Integer/Rational no longer compare equal with a == b. From now on Float(2.0) != Integer(2). Previously expressions involving Float would compare unequal e.g. x*2.0 != x*2 but an individual Float would compare equal to an Integer. In SymPy 1.7 a Float will always compare unequal to an Integer even if they have the same "value". Use sympy.numbers.int_valued(number) to test if a number is a concrete number with no decimal part. ([pytorch#25614](sympy/sympy#25614) by [@smichr](https://github.com/smichr)) `sympy >= 1.13.0` is required to enable Python 3.13 support. This should be part of pytorch#130689. - pytorch#130689 Pull Request resolved: pytorch#130895 Approved by: https://github.com/ezyang
DiweiSun
pushed a commit
to DiweiSun/pytorch
that referenced
this pull request
Jul 22, 2024
0.12.0 Major Updates: - Add context manager to temporarily set the dictionary sorting mode - Add accessor APIs - Use `stable` tag for `pybind11` for Python 3.13 support - Fix potential segmentation fault for pickling support 0.12.1 Updates: - Fix warning regression during import when launch with strict warning filters Closes pytorch#130155 Pull Request resolved: pytorch#130139 Approved by: https://github.com/zou3519 ghstack dependencies: pytorch#130895
DiweiSun
pushed a commit
to DiweiSun/pytorch
that referenced
this pull request
Jul 22, 2024
Pull Request resolved: pytorch#130144 Approved by: https://github.com/zou3519 ghstack dependencies: pytorch#130895, pytorch#130139
|
@XuehaiPan this is actually breaking nighlty builds on conda because only sympy up to 1.12.0 seems to be available there: https://anaconda.org/anaconda/sympy/files |
@albanD We may need to open an issue here (https://github.com/ContinuumIO/anaconda-issues/issues?q=label%3Apackage_request+) to request a version update. The short-term solution is to loosen the constraint to |
XilunWu
reviewed
Jul 22, 2024
pytorchmergebot
pushed a commit
that referenced
this pull request
Jul 23, 2024
Fixing nightly after #130895 Pull Request resolved: #131355 Approved by: https://github.com/atalman
XuehaiPan
pushed a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jul 23, 2024
…131355) Fixing nightly after pytorch#130895 Pull Request resolved: pytorch#131355 Approved by: https://github.com/atalman
XuehaiPan
pushed a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jul 24, 2024
…131355) Fixing nightly after pytorch#130895 Pull Request resolved: pytorch#131355 Approved by: https://github.com/atalman
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Jul 25, 2024
------ The opposite of pytorch#130836. Pin `sympy >= 1.13.0` for Python >= 3.9 and `sympy == 1.12.1` for Python 3.8. - pytorch#130836 See the PR description of pytorch#130836 for more details. `sympy` 1.13.0 introduces some breaking changes which break our tests. More specifically: - Ref [Backwards compatibility breaks and deprecations](https://github.com/sympy/sympy/wiki/release-notes-for-1.13.0#backwards-compatibility-breaks-and-deprecations) > BREAKING CHANGE: Float and Integer/Rational no longer compare equal with a == b. From now on Float(2.0) != Integer(2). Previously expressions involving Float would compare unequal e.g. x*2.0 != x*2 but an individual Float would compare equal to an Integer. In SymPy 1.7 a Float will always compare unequal to an Integer even if they have the same "value". Use sympy.numbers.int_valued(number) to test if a number is a concrete number with no decimal part. ([pytorch#25614](sympy/sympy#25614) by [@smichr](https://github.com/smichr)) `sympy >= 1.13.0` is required to enable Python 3.13 support. This should be part of pytorch#130689. - pytorch#130689 Pull Request resolved: pytorch#130895 Approved by: https://github.com/ezyang
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Jul 25, 2024
0.12.0 Major Updates: - Add context manager to temporarily set the dictionary sorting mode - Add accessor APIs - Use `stable` tag for `pybind11` for Python 3.13 support - Fix potential segmentation fault for pickling support 0.12.1 Updates: - Fix warning regression during import when launch with strict warning filters Closes pytorch#130155 Pull Request resolved: pytorch#130139 Approved by: https://github.com/zou3519 ghstack dependencies: pytorch#130895
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Jul 25, 2024
Pull Request resolved: pytorch#130144 Approved by: https://github.com/zou3519 ghstack dependencies: pytorch#130895, pytorch#130139
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Jul 25, 2024
…131355) Fixing nightly after pytorch#130895 Pull Request resolved: pytorch#131355 Approved by: https://github.com/atalman
|
Is there anything we can do to relax this version pin? Would make compatibility in large environments easier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
dictkeys in insertion order in CXX pytree #130140torch::deploy#130144optreeversion to 0.12.1 #130139sympy >= 1.13.0#130895The opposite of #130836. Pin
sympy >= 1.13.0for Python >= 3.9 andsympy == 1.12.1for Python 3.8.sympy < 1.13.0a0#130836See the PR description of #130836 for more details.
sympy1.13.0 introduces some breaking changes which break our tests. More specifically:sympy >= 1.13.0is required to enable Python 3.13 support. This should be part of #130689.cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @seemethere @malfet @pytorch/pytorch-dev-infra @voznesenskym @penguinwu @EikanWang @Guobing-Chen @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang