8000 Cherry pick #129244, #129251, #129239, 129396 into release/2.4 by mikaylagawarecki · Pull Request #129478 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Cherry pick #129244, #129251, #129239, 129396 into release/2.4 #129478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 26, 2024
Merged

Cherry pick #129244, #129251, #129239, 129396 into release/2.4 #129478

merged 4 commits into from
Jun 26, 2024

Conversation

mikaylagawarecki
Copy link
Contributor
@mikaylagawarecki mikaylagawarecki commented Jun 25, 2024 •
edited by pytorch-bot bot
Loading

@mikaylagawarecki
Fix allowlisting of builtins for weights_only unpickler
2251322 
ghstack-source-id: de329c7
Pull Request resolved: pytorch#129244

(cherry picked from commit cc99c01)
@mikaylagawarecki
Allow NEWOBJ instruction for items added via torch.serialization.add_…
667dcf7 
…safe_globals

ghstack-source-id: 34a8fc3
Pull Request resolved: pytorch#129251

(cherry picked from commit 50b888d)
@mikaylagawarecki
Add warning for weights_only
263d68e 
ghstack-source-id: ffa772c
Pull Request resolved: pytorch#129239

(cherry picked from commit b3f9aa3f8f4c03b40fed53423d4a0a9340e3bd09)
@mikaylagawarecki
Add example for torch.serialization.add_safe_globals
cfcc420 
ghstack-source-id: 6dc3275
Pull Request resolved: pytorch#129396

(cherry picked from commit ed8c36eda0f4dcf7b1d9c5eb2fb1cdccdf3fee6e)
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Jun 25, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/129478

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 2 Unrelated Failures

As of commit cfcc420 with merge base b66e3f0 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: nn release notes category labels Jun 25, 2024
@mikaylagawarecki mikaylagawarecki mentioned this pull request Jun 25, 2024
Closed
@mikaylagawarecki mikaylagawarecki added the suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter) label Jun 25, 2024
@mikaylagawarecki
Copy link
Contributor Author

Failures are unrelated

atalman
atalman approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor
@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @mikaylagawarecki for cherry-picks if possible please provide separate cherry picks rather then squishing everything into one large cherry pick

@atalman atalman merged commit 22a4d46 into pytorch:release/2.4 Jun 26, 2024
99 of 104 checks passed
atalman added a commit that referenced this pull request Jun 26, 2024
@atalman
Revert "Cherry pick #129244, #129251, #129239, 129396 into release/2.4 (
f0bde90 
#129478)"

This reverts commit 22a4d46.
@atalman atalman mentioned this pull request Jun 26, 2024
Merged
atalman added a commit that referenced this pull request Jun 26, 2024
@atalman
Revert "Cherry pick #129244, #129251, #129239, 129396 into release/2.…
4d83bca 
…4" (#129571)

Revert "Cherry pick #129244, #129251, #129239, 129396 into release/2.4 (#129478)"

This reverts commit 22a4d46.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atalman atalman atalman approved these changes

Assignees
No one assigned
Labels
oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: nn release notes category suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikaylagawarecki @atalman
0