8000 Update torchbench model expected accuracy values after pinning numpy by huydhn · Pull Request #129213 · pytorch/pytorch · GitHub
[go: up one dir, main page]

Skip to content

Update torchbench model expected accuracy values after pinning numpy #129213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

huydhn
Copy link
Contributor
@huydhn huydhn commented Jun 21, 2024

After pinning numpy on torchbench, we need to move torchbench inductor benchmark jobs out of unstable state asap, so that more failures don't sneak it. I'm updating the expected values here to make trunk green.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang

@huydhn huydhn requested review from xuzhao9, desertfire and a team June 21, 2024 05:43
Copy link
pytorch-bot bot commented Jun 21, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/129213

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (5 Unrelated Failures)

As of commit 730d831 with merge base b542825 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@@ -2,142 +2,6 @@ name,accuracy,graph_breaks



torchrec_dlrm,pass,6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason for deleting this large chunk?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok, good catch, I ran python benchmarks/dynamo/ci_expected_accuracy/update_expected.py c027c8935b25cdb99fce5595fa1a980df8cdb4ab on a regular trunk commit, I need to rerun this on one with inductor periodic jobs

@huydhn
Copy link
Contributor Author
huydhn commented Jun 22, 2024

@pytorchbot merge -f 'ROCm queue'

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

8000
@huydhn
Copy link
Contributor Author
huydhn commented Jul 2, 2024

@pytorchbot cherry-pick --onto release/2.4 -c release --fixes 'Update inductor expected results after pinning numpy on TorchBench'

pytorchbot pushed a commit that referenced this pull request Jul 2, 2024
…129213)

After pinning numpy on torchbench, we need to move torchbench inductor benchmark jobs out of unstable state asap, so that more failures don't sneak it.  I'm updating the expected values here to make trunk green.

Pull Request resolved: #129213
Approved by: https://github.com/xuzhao9, https://github.com/malfet, https://github.com/desertfire

(cherry picked from commit b72ef9d)
@pytorchbot
Copy link
Collaborator

Cherry picking #129213

The cherry pick PR is at #129986 and it is linked with issue Update inductor expected results after pinning numpy on TorchBench. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

atalman pushed a commit that referenced this pull request Jul 4, 2024
…129986)

* Update torchbench model expected accuracy values after pinning numpy (#129213)

After pinning numpy on torchbench, we need to move torchbench inductor benchmark jobs out of unstable state asap, so that more failures don't sneak it.  I'm updating the expected values here to make trunk green.

Pull Request resolved: #129213
Approved by: https://github.com/xuzhao9, https://github.com/malfet, https://github.com/desertfire

(cherry picked from commit b72ef9d)

* No change to yolov3

---------

Co-authored-by: Huy Do <huydhn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
0