8000 Remove leftover warning causing log spew by lw · Pull Request #128688 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Remove leftover warning causing log spew #128688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Remove leftover warning causing log spew #128688

wants to merge 1 commit into from

Conversation

lw
Copy link
Contributor
@lw lw commented Jun 14, 2024

This warning was left by mistake, and is uninformative (the user is doing nothing wrong) and causing log spew in trainings. See #120750 (comment)

@lw
Remove leftover warning causing log spew
d3604d0 
This warning was left by mistake, and is uninformative (the user is doing nothing wrong) and causing log spew in trainings. See #120750 (comment)
@lw lw requested review from eqy and drisspg June 14, 2024 08:10
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Jun 14, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/128688

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit d3604d0 with merge base 0344f95 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@lw lw mentioned this pull request Jun 14, 2024
Closed
@drisspg drisspg added this to the 2.4.0 milestone Jun 14, 2024
@drisspg
Copy link
Contributor
drisspg commented Jun 14, 2024

@atalman is the 2.4.0 milestone the correct one for cherry picks?

@lw
Copy link
Contributor Author
lw commented Jun 14, 2024 •
edited
Loading

@pytorchbot merge -f 'Bypass flaky check'

@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Jun 14, 2024

You need to provide a reason for using force merge, in the format @pytorchbot merge -f 'Explanation'.
The explanation needs to be clear on why this is needed. Here are some good examples:

  • Bypass checks due to unrelated upstream failures from ...
  • This is a minor fix to ..., which shouldn't break anything
  • This is pre-tested in a previous CI run
  • Bypass flaky ... check

@lw
Copy link
Contributor Author
lw commented Jun 14, 2024

@pytorchbot merge -f 'Bypass flaky job'

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

ignaciobartol pushed a commit to ignaciobartol/pytorch that referenced this pull request Jun 14, 2024
@lw @ignaciobartol
Remove leftover warning causing log spew (pytorch#128688)
a8317f9 
This warning was left by mistake, and is uninformative (the user is doing nothing wrong) and causing log spew in trainings. See pytorch#120750 (comment)
Pull Request resolved: pytorch#128688
Approved by: https://github.com/drisspg
lw added a commit that referenced this pull request Jun 17, 2024
@lw
Remove leftover warning causing log spew
74f3f2b 
Original PR: #128688

This warning was left by mistake, and is uninformative (the user is doing nothing wrong) and causing log spew in trainings. See #120750 (comment)
This was referenced Jun 17, 2024
Merged
Closed
atalman pushed a commit that referenced this pull request Jun 19, 2024
@lw
Remove leftover warning causing log spew (#128837)
edcc77d 
Original PR: #128688

This warning was left by mistake, and is uninformative (the user is doing nothing wrong) and causing log spew in trainings. See #120750 (comment)
@atalman atalman mentioned this pull request Jul 5, 2024
Closed
29 tasks
@github-actions github-actions bot deleted the lw-patch-1 branch July 15, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drisspg drisspg drisspg approved these changes

@eqy eqy Awaiting requested review from eqy

Assignees
No one assigned
Labels
Merged
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lw @drisspg @pytorchmergebot
0