Revert "Make torch_geometric models compatible with export (#123403)" #128377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d78991a. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/128377
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (3 Unrelated Failures)As of commit de9e1bf with merge base 8a09940 ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jgong5
approved these changes
Jun 11, 2024
angelayi
approved these changes
Jun 11, 2024
benchmarks/dynamo/torchbench.py
Outdated
|
|
||
| model._register_state_dict_hook(state_dict_hook) | ||
|
|
||
|
|
There was a problem hiding this comment.
I think we can still keep this change?
There was a problem hiding this comment.
I've added that back and only changed the export related part
…#123403)"" This reverts commit d78991a. This PR reverts #123403 to fix the performance regression as discussed in #127513 (comment). cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
|
Is the idea to cherry-pick this to the 2.4 branch? |
desertfire
approved these changes
Jun 12, 2024
Yes, I plan to submit a cherry-pick PR to 2.4 when the current PR lands to main. |
|
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
|
Successfully rebased |
pytorchmergebot
pushed a commit
that referenced
this pull request
Jun 12, 2024
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
chunyuan-w
added a commit
to chunyuan-w/pytorch
that referenced
this pull request
Jun 12, 2024
…23403)" (pytorch#128377) This reverts commit d78991a. This PR reverts pytorch#123403 to fix the performance regression as discussed in pytorch#127513 (comment). Pull Request resolved: pytorch#128377 Approved by: https://github.com/jgong5, https://github.com/angelayi, https://github.com/desertfire (cherry picked from commit 5ef70fa)
facebook-github-bot
pushed a commit
to pytorch/benchmark
that referenced
this pull request
Jun 13, 2024
… (#128377) Summary: This reverts commit d78991a7381adb3df5e9b63c365db4506643edce. This PR reverts pytorch/pytorch#123403 to fix the performance regression as discussed in pytorch/pytorch#127513 (comment). X-link: pytorch/pytorch#128377 Approved by: https://github.com/jgong5, https://github.com/angelayi, https://github.com/desertfire Reviewed By: clee2000 Differential Revision: D58501783 fbshipit-source-id: 1e55cc2c0b315ed6869195ee6730e72eb6be9da9
TharinduRusira
pushed a commit
to TharinduRusira/pytorch
that referenced
this pull request
Jun 14, 2024
…23403)" (pytorch#128377) This reverts commit d78991a. This PR reverts pytorch#123403 to fix the performance regression as discussed in pytorch#127513 (comment). Pull Request resolved: pytorch#128377 Approved by: https://github.com/jgong5, https://github.com/angelayi, https://github.com/desertfire
ignaciobartol
pushed a commit
to ignaciobartol/pytorch
that referenced
this pull request
Jun 14, 2024
…23403)" (pytorch#128377) This reverts commit d78991a. This PR reverts pytorch#123403 to fix the performance regression as discussed in pytorch#127513 (comment). Pull Request resolved: pytorch#128377 Approved by: https://github.com/jgong5, https://github.com/angelayi, https://github.com/desertfire
atalman
pushed a commit
that referenced
this pull request
Jun 19, 2024
#128511) Revert "Make torch_geometric models compatible with export (#123403)" (#128377) This reverts commit d78991a. This PR reverts #123403 to fix the performance regression as discussed in #127513 (comment). Pull Request resolved: #128377 Approved by: https://github.com/jgong5, https://github.com/angelayi, https://github.com/desertfire (cherry picked from commit 5ef70fa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This reverts commit d78991a.
This PR reverts #123403 to fix the performance regression as discussed in #127513 (comment).
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang