8000 Add symbolic_shape_specialization structured trace by ezyang · Pull Request #126450 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Add symbolic_shape_specialization structured trace #126450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add symbolic_shape_specialization structured trace #126450

wants to merge 2 commits into from

Conversation

ezyang
Copy link
Contributor
@ezyang ezyang commented May 16, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

This is typically the information you want when diagnosing why something
overspecialized in dynamic shapes.

Signed-off-by: Edward Z. Yang ezyang@meta.com

@ezyang
Update
77e4b09 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented May 16, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126450

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 4ec95ff with merge base 2f53747 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/inductor release notes: fx release notes category labels May 16, 2024
ezyang added a commit that referenced this pull request May 16, 2024
@ezyang
Add symbolic_shape_specialization structured trace
39472c2 
This is typically the information you want when diagnosing why something
overspecialized in dynamic shapes.

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

ghstack-source-id: 80d5eca
Pull Request resolved: #126450
@ezyang ezyang requested a review from Chillee May 16, 2024 20:27
@ezyang
Copy link
Contributor Author
ezyang commented May 16, 2024

@pytorchbot merge -i

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 16, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 6 checks: inductor / cuda12.1-py3.10-gcc9-sm86 / test (inductor_torchbench, 1, 2, linux.g5.4xlarge.nvidia.gpu, unstable), inductor / cuda12.1-py3.10-gcc9-sm86 / test (dynamic_inductor_torchbench, 1, 2, linux.g5.4xlarge.nvidia.gpu, unstable), inductor / cuda12.1-py3.10-gcc9-sm86 / test (aot_inductor_torchbench, 1, 2, linux.g5.4xlarge.nvidia.gpu, unstable), inductor-periodic / cuda12.1-py3.10-gcc9-sm86-periodic-dynamo-benchmarks / test (dynamo_eager_torchbench, 1, 2, linux.g5.4xlarge.nvidia.gpu), inductor-periodic / cuda12.1-py3.10-gcc9-sm86-periodic-dynamo-benchmarks / test (aot_eager_torchbench, 1, 2, linux.g5.4xlarge.nvidia.gpu), inductor-periodic / cuda12.1-py3.10-gcc9-sm86-periodic-dynamo-benchmarks / test (dynamic_aot_eager_torchbench, 1, 2, linux.g5.4xlarge.nvidia.gpu)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

ZelboK pushed a commit to ZelboK/pytorch that referenced this pull request May 19, 2024
@ezyang @ZelboK
Add symbolic_shape_specialization structured trace (pytorch#126450)
6fc8524 
This is typically the information you want when diagnosing why something
overspecialized in dynamic shapes.

Signed-off-by: Edward Z. Yang <ezyang@meta.com>
Pull Request resolved: pytorch#126450
Approved by: https://github.com/albanD
@DanilBaibak
Copy link
Contributor

@pytorchbot revert -m "Break internal build" -c ghfirst

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request May 20, 2024
@pytorchmergebot
Revert "Add symbolic_shape_specialization structured trace (#126450)"
53f73cd 
This reverts commit da1fc85.

Reverted #126450 on behalf of https://github.com/DanilBaibak due to Break internal build ([comment](#126450 (comment)))
@pytorchmergebot
Copy link
Collaborator
8000

@ezyang your PR has been successfully reverted.

@github-actions github-actions bot requested a review from albanD May 20, 2024 07:00
@DanilBaibak
Copy link
Contributor

Hi @ezyang! Sorry, I need to revert your PR because it breaks the internal build. Here you can find more information about the issue - D57518787.

@ezyang
Update
4ec95ff 
[ghstack-poisoned]
ezyang added a commit that referenced this pull request May 20, 2024
@ezyang
Add symbolic_shape_specialization structured trace
fd64025 
This is typically the information you want when diagnosing why something
overspecialized in dynamic shapes.

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

ghstack-source-id: 081c77e
Pull Request resolved: #126450
@ezyang
Copy link
Contributor Author
ezyang commented May 20, 2024

@pytorchbot merge
8000

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@albanD albanD removed their request for review May 20, 2024 14:08
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 18 jobs have failed, first few of them are: inductor / cuda12.1-py3.10-gcc9-sm86 / test (inductor, 1, 1, linux.g5.4xlarge.nvidia.gpu, unstable), inductor / cuda12.1-py3.10-gcc9-sm86 / test (inductor_distributed, 1, 1, linux.g5.12xlarge.nvidia.gpu, unstable), inductor / cuda12.1-py3.10-gcc9-sm86 / test (inductor_huggingface, 1, 1, linux.g5.4xlarge.nvidia.gpu, unstable), inductor / cuda12.1-py3.10-gcc9-sm86 / test (inductor_timm, 1, 2, linux.g5.4xlarge.nvidia.gpu, unstable), inductor / cuda12.1-py3.10-gcc9-sm86 / test (inductor_timm, 2, 2, linux.g5.4xlarge.nvidia.gpu, unstable)

Details for Dev Infra team Raised by workflow job

@ezyang
Copy link
Contributor Author
8000 ezyang commented May 21, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/ezyang/2774/head branch June 20, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albanD albanD albanD approved these changes

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

@miladm miladm Awaiting requested review from miladm

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

@Chillee Chillee Awaiting requested review from Chillee

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: fx release notes category Reverted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ezyang @pytorchmergebot @DanilBaibak @albanD
0