8000 Remove caffe2 contrib and experiments by cyyever · Pull Request #125038 · pytorch/pytorch · GitHub
[go: up one dir, main page]

Skip to content

Remove caffe2 contrib and experiments #125038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

cyyever
Copy link
Collaborator
@cyyever cyyever commented Apr 26, 2024

Copy link
pytorch-bot bot commented Apr 26, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125038

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f3a457a with merge base ce503c1 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Apr 26, 2024
@cyyever cyyever added topic: build module: build Build system issues module: bazel module: cpp Related to C++ API skip-pr-sanity-checks topic: bc breaking topic category suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter) labels Apr 26, 2024
@cyyever cyyever requested a review from malfet April 26, 2024 16:16
Copy link
Contributor
@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if it passes the CI, but it should be landed as co-dev
cc: @r-barnes @izaitsevfb

@r-barnes
Copy link
Contributor

@cyyever - I'll be helping you land this by disabling an internal sync once this is ready. Could you ping me when you have passing tests?

@r-barnes
Copy link
Contributor

Also, #122527 only has 4 test failures now, so we might be able to pursue that directly.

@thiagocrepaldi thiagocrepaldi removed the release notes: onnx torch.onnx related changes that should show up in the release notes label Apr 26, 2024
@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Apr 27, 2024
@cyyever cyyever changed the title Remove caffe2 operators and contrib Remove caffe2 operators, contrib and experiments Apr 27, 2024
@cyyever cyyever force-pushed the caffe2_ops branch 4 times, most recently from de98193 to 3e1110a Compare April 27, 2024 07:06
@cyyever cyyever changed the title Remove caffe2 operators, contrib and experiments Remove caffe2 contrib and experiments Apr 27, 2024
@pytorch-bot pytorch-bot bot added the module: mkldnn Related to Intel IDEEP or oneDNN (a.k.a. mkldnn) integration label Apr 27, 2024
@cyyever cyyever requested a review from malfet April 27, 2024 14:04
@cyyever
Copy link
Collaborator Author
cyyever commented Apr 27, 2024

@r-barnes It is ready.

@cyyever cyyever added caffe2 ciflow/trunk Trigger trunk jobs on your pull request topic: deprecation topic category topic: bc_breaking labels Apr 29, 2024
@cyyever
Copy link
Collaborator Author
cyyever commented Apr 29, 2024

@r-barnes You mentioned that META has been not synced with Caffe2, so it may be safe to merge without breaking META builds.

@cyyever
Copy link
Collaborator Author
cyyever commented Apr 29, 2024

@pytorchmergebot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@r-barnes
Copy link
Contributor

@cyyever - I did ask you to ping me when this was ready. Landing it without getting a response from me is causing problems internally :-(

@r-barnes
Copy link
Contributor
r-barnes commented Apr 29, 2024

Desyncing with D56711054.

@r-barnes
Copy link
Contributor

I'll post here again when the desync has landed.

@r-barnes
Copy link
Contributor

D56711054 landed, so we're good internally.

petrex pushed a commit to petrex/pytorch that referenced this pull request May 3, 2024
This PR tries to decompose pytorch#122527 into a smaller one.
To be noted, this was inspired and is co-dev with @r-barnes.

Pull Request resolved: pytorch#125038
Approved by: https://github.com/malfet
@cyyever cyyever deleted the caffe2_ops branch May 18, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
caffe2 ciflow/trunk Trigger trunk jobs on your pull request Merged module: bazel module: build Build system issues module: cpp Related to C++ API module: mkldnn Related to Intel IDEEP or oneDNN (a.k.a. mkldnn) integration open source release notes: onnx torch.onnx related changes that should show up in the release notes skip-pr-sanity-checks suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter) topic: bc breaking topic category topic: build topic: deprecation topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
0