-
Notifications
You must be signed in to change notification settings - Fork 24.7k
[Inductor] Update Intel GPU Triton commit pin. #124842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/124842
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Cancelled Job, 2 Unrelated FailuresAs of commit 520a187 with merge base 88974fe ( NEW FAILURE - The following job has failed:
CANCELLED JOB - The following job was cancelled. Please retry:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason for the update? Can changes affecting pytorch, please, be briefly summarized both on commit message and in PR summary. If there are particular known issues filed at pytorch or xpu triton project affecting pytorch it would be nice to have them called out.
I also suggest that it would be better to have a single commit with good commit message. For details, you can link to the project difference: intel/intel-xpu-backend-for-triton@b8c64f6...dd07225
Finally, https://github.com/intel/intel-xpu-backend-for-triton/tags has tags, but it seems they are not associated with the commit ids used here on pytorch side. It probable makes sense to consider correlation of pytorch commit pin updates with https://github.com/intel/intel-xpu-backend-for-triton release/validation cycles.
[ghstack-poisoned]
@dvrogozh , Regarding Triton commit pin update, we are following torch.compile pass criteria. |
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang [ghstack-poisoned]
Ready to land: @pytorchbot merge -i |
Merge startedYour change will be merged while ignoring the following 4 checks: pull / linux-jammy-py3.8-gcc11 / test (distributed, 1, 2, linux.2xlarge), inductor / cuda12.1-py3.10-gcc9-sm86 / test (dynamic_inductor_timm, 1, 2, linux.g5.4xlarge.nvidia.gpu), inductor / cuda12.1-py3.10-gcc9-sm80 / test (inductor_torchbench_smoketest_perf, 1, 1, linux.gcp.a100), trunk / linux-focal-cuda12.4-py3.10-gcc9-sm86 / test (default, 5, 5, linux.g5.4xlarge.nvidia.gpu) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Update Intel triton for Pytorch 2.4 release. Pull Request resolved: pytorch#124842 Approved by: https://github.com/EikanWang (cherry picked from commit cf7adc2)
Update Intel triton for Pytorch 2.4 release. Pull Request resolved: pytorch#124842 Approved by: https://github.com/EikanWang
Update Intel triton for Pytorch 2.4 release. Pull Request resolved: pytorch#124842 Approved by: https://github.com/EikanWang
Update Intel triton for Pytorch 2.4 release. Pull Request resolved: #124842 Approved by: https://github.com/EikanWang (cherry picked from commit cf7adc2)
Stack from ghstack (oldest at bottom):
Update Intel triton for Pytorch 2.4 release.
cc @jgong5 8000 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @voznesenskym @penguinwu @EikanWang @Guobing-Chen @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang