8000 [Inductor] Update Intel GPU Triton commit pin. by etaf · Pull Request #124842 · pytorch/pytorch · GitHub
[go: up one dir, main page]

Skip to content

[Inductor] Update Intel GPU Triton commit pin. #124842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 33 commits into from

Conversation

@etaf etaf requested a review from jeffdaily as a code owner April 24, 2024 13:57
Copy link
pytorch-bot bot commented Apr 24, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/124842

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Cancelled Job, 2 Unrelated Failures

As of commit 520a187 with merge base 88974fe (image):

NEW FAILURE - The following job has failed:

CANCELLED JOB - The following job was cancelled. Please retry:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

etaf added a commit that referenced this pull request Apr 24, 2024
ghstack-source-id: 3b5393b
Pull Request resolved: #124842
@etaf etaf requested a review from EikanWang April 24, 2024 13:58
@etaf etaf closed this Apr 26, 2024
@etaf etaf reopened this May 8, 2024
@etaf etaf added the ciflow/xpu Run XPU CI tasks label May 8, 2024
Copy link
Contributor
@dvrogozh dvrogozh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for the update? Can changes affecting pytorch, please, be briefly summarized both on commit message and in PR summary. If there are particular known issues filed at pytorch or xpu triton project affecting pytorch it would be nice to have them called out.

I also suggest that it would be better to have a single commit with good commit message. For details, you can link to the project difference: intel/intel-xpu-backend-for-triton@b8c64f6...dd07225

Finally, https://github.com/intel/intel-xpu-backend-for-triton/tags has tags, but it seems they are not associated with the commit ids used here on pytorch side. It probable makes sense to consider correlation of pytorch commit pin updates with https://github.com/intel/intel-xpu-backend-for-triton release/validation cycles.

@EikanWang
Copy link
Collaborator

@dvrogozh , Regarding Triton commit pin update, we are following torch.compile pass criteria.

@etaf etaf marked this pull request as draft May 14, 2024 02:29
@etaf etaf changed the title [Inductor] Update Intel GPU Triton commit pin. [WIP][Inductor] Update Intel GPU Triton commit pin. May 14, 2024
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
etaf added 5 commits June 3, 2024 17:50
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@etaf etaf added intel This tag is for PR from Intel labels Jun 7, 2024
etaf added 5 commits June 7, 2024 07:07
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@etaf etaf changed the title [WIP][Inductor] Update Intel GPU Triton commit pin. [Inductor] Update Intel GPU Triton commit pin. Jun 13, 2024
@etaf etaf marked this pull request as ready for review June 13, 2024 10:37
@etaf etaf requested a review from gujinghui as a code owner June 13, 2024 10:37
@etaf
Copy link
Collaborator Author
etaf commented Jun 13, 2024

Ready to land:
unreleated failure trunk / linux-focal-cuda12.4-py3.10-gcc9-sm86 / test (default, 5, 5, linux.g5.4xlarge.nvidia.gpu) (gh)
canceled long queued unrelated job: inductor / cuda12.1-py3.10-gcc9-sm80 / test (inductor_torchbench_smoketest_perf, 1, 1, linux.gcp.a100) (push)

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

etaf added a commit to etaf/pytorch-inductor-xpu that referenced this pull request Jun 13, 2024
Update Intel triton for Pytorch 2.4 release.

Pull Request resolved: pytorch#124842
Approved by: https://github.com/EikanWang

(cherry picked from commit cf7adc2)
TharinduRusira pushed a commit to TharinduRusira/pytorch that referenced this pull request Jun 14, 2024
Update Intel triton for Pytorch 2.4 release.

Pull Request resolved: pytorch#124842
Approved by: https://github.com/EikanWang
ignaciobartol pushed a commit to ignaciobartol/pytorch that referenced this pull request Jun 14, 2024
Update Intel triton for Pytorch 2.4 release.

Pull Request resolved: pytorch#124842
Approved by: https://github.com/EikanWang
atalman pushed a commit that referenced this pull request Jun 19, 2024
Update Intel triton for Pytorch 2.4 release.

Pull Request resolved: #124842
Approved by: https://github.com/EikanWang

(cherry picked from commit cf7adc2)
@github-actions github-actions bot deleted the gh/etaf/13/head branch July 14, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request ciflow/xpu Run XPU CI tasks intel This tag is for PR from Intel Merged module: inductor open source topic: not user facing topic category
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants
0