10000 Fixes format utils executable by LucasLLC · Pull Request #123407 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Fixes format utils executable #123407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fixes format utils executable #123407

wants to merge 2 commits into from

Conversation

LucasLLC
Copy link
Contributor
@LucasLLC LucasLLC commented Apr 5, 2024 •
edited by pytorch-bot bot
Loading

@LucasLLC LucasLLC requested a review from wz337 April 5, 2024 00:12
@LucasLLC LucasLLC self-assigned this Apr 5, 2024
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Apr 5, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/123407

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 1856bf0 with merge base e0c9764 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added module: distributed_checkpoint oncall: distributed Add this issue/PR to distributed oncall triage queue labels Apr 5, 2024
@LucasLLC LucasLLC requested a review from fegin April 5, 2024 00:17
wz337
wz337 approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor
@wz337 wz337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@LucasLLC
Copy link
Contributor Author
LucasLLC commented Apr 5, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 5, 2024
fegin
fegin approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor
@fegin fegin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@LucasLLC LucasLLC added the topic: not user facing topic category label Apr 5, 2024
@LucasLLC
Copy link
Contributor Author
LucasLLC commented Apr 5, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@huydhn huydhn added this to the 2.3.1 milestone Apr 5, 2024
@huydhn
Copy link
Contributor
huydhn commented Apr 5, 2024

@pytorchbot --help

@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Apr 5, 2024

PyTorchBot Help

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci,cherry-pick,close} ...

In order to invoke the bot on your PR, include a line that starts with
@pytorchbot anywhere in a comment. That line will form the command; no
multi-line commands are allowed. Some commands may be used on issues as specified below.

Example:
    Some extra context, blah blah, wow this PR looks awesome

    @pytorchbot merge

optional arguments:
  -h, --help            Show this help message and exit.

command:
  {merge,revert,rebase,label,drci,cherry-pick,close}
    merge               Merge a PR
    revert              Revert a PR
    rebase              Rebase a PR
    label               Add label to a PR
    drci                Update Dr. CI
    cherry-pick         Cherry pick a PR onto a release branch
    close               Close a PR

Merge

usage: @pytorchbot merge [-f MESSAGE | -i] [-ic] [-r [{viable/strict,main}]]

Merge an accepted PR, subject to the rules in .github/merge_rules.json.
By default, this will wait for all required checks (lint, pull) to succeed before merging.

optional arguments:
  -f MESSAGE, --force MESSAGE
                        Merge without checking anything. This requires a reason for auditting purpose, for example:
                        @pytorchbot merge -f 'Minor update to fix lint. Expecting all PR tests to pass'
                        
                        Please use `-f` as last resort, prefer `--ignore-current` to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.
  -i, --ignore-current  Merge while ignoring the currently failing jobs.  Behaves like -f if there are no pending jobs.
  -ic                   Old flag for --ignore-current. Deprecated in favor of -i.
  -r [{viable/strict,main}], --rebase [{viable/strict,main}]
                        Rebase the PR to re run checks before merging.  Accepts viable/strict or main as branch options and will default to viable/strict if not specified.

Revert

usage: @pytorchbot revert -m MESSAGE -c
                          {nosignal,ignoredsignal,landrace,weird,ghfirst}

Revert a merged PR. This requires that you are a Meta employee.

Example:
  @pytorchbot revert -m="This is breaking tests on trunk. hud.pytorch.org/" -c=nosignal

optional arguments:
  -m MESSAGE, --message MESSAGE
                        The reason you are reverting, will be put in the commit message. Must be longer than 3 words.
  -c {nosignal,ignoredsignal,landrace,weird,ghfirst}, --classification {nosignal,ignoredsignal,landrace,weird,ghfirst}
                        A machine-friendly classification of the revert reason.

Rebase

usage: @pytorchbot rebase [-s | -b BRANCH]

Rebase a PR. Rebasing defaults to the stable viable/strict branch of pytorch.
Repeat contributor may use this command to rebase their PR.

optional arguments:
  -s, --stable          [DEPRECATED] Rebase onto viable/strict
  -b BRANCH, --branch BRANCH
                        Branch you would like to rebase to

Label

usage: @pytorchbot label labels [labels ...]

Adds label to a PR or Issue [Can be used on Issues]

positional arguments:
  labels  Labels to add to given Pull Request or Issue [Can be used on Issues]

Dr CI

usage: @pytorchbot drci 

Update Dr. CI. Updates the Dr. CI comment on the PR in case it's gotten out of sync with actual CI results.

cherry-pick

usage: @pytorchbot cherry-pick --onto ONTO [--fixes FIXES] -c
                               {regression,critical,fixnewfeature,docs,release}

Cherry pick a pull request onto a release branch for inclusion in a release

optional arguments:
  --onto ONTO           Branch you would like to cherry pick onto (Example: release/2.1)
  --fixes FIXES         Link to the issue that your PR fixes (Example: https://github.com/pytorch/pytorch/issues/110666)
  -c {regression,critical,fixnewfeature,docs,release}, --classification {regression,critical,fixnewfeature,docs,release}
                        A machine-friendly classification of the cherry-pick reason.

Close

usage: @pytorchbot close

Close a PR [Can be used on issues]

@huydhn
Copy link
Contributor
huydhn commented Apr 5, 2024

@pytorchbot cherry-pick --onto release/2.3 -c fixnewfeature

@huydhn
Copy link
Contributor
huydhn commented Apr 5, 2024

Checking with @atalman that we don't accept any more cherry picks for 2.3.0, so let's get this one queue for 2.3.1

pytorchbot pushed a commit that referenced this pull request Apr 5, 2024
@LucasLLC @pytorchbot
Fixes format utils executable (#123407)
1ab823a 
Fixes an issue with the format utils executable, which was causing it to run as a no-op. :(

Pull Request resolved: #123407
Approved by: https://github.com/wz337, https://github.com/fegin

(cherry picked from commit 18c9d46)
@pytorchbot
Copy link
Collaborator

Cherry picking #123407

The cherry pick PR is at #123482 and it is recommended to link a fixnewfeature cherry pick PR with an issue

Details for Dev Infra team Raised by workflow job

@huydhn
Copy link
Contributor
huydhn commented Apr 5, 2024

#123482 can be the cherry pick PR for 2.3.1

sanketpurandare pushed a commit to sanketpurandare/pytorch that referenced this pull request Apr 22, 2024
@LucasLLC
Fixes format utils executable (pytorch#123407)
a62e5c1 
Fixes an issue with the format utils executable, which was causing it to run as a no-op. :(

Pull Request resolved: pytorch#123407
Approved by: https://github.com/wz337, https://github.com/fegin
@github-actions github-actions bot deleted the fix_format_utils branch May 6, 2024 01:53
@atalman atalman mentioned this pull request May 13, 2024
Closed
huydhn pushed a commit that referenced this pull request May 13, 2024
@pytorchbot @LucasLLC
Fixes format utils executable (#123482)
c365674 
Fixes format utils executable (#123407)

Fixes an issue with the format utils executable, which was causing it to run as a no-op. :(

Pull Request resolved: #123407
Approved by: https://github.com/wz337, https://github.com/fegin

(cherry picked from commit 18c9d46)

Co-authored-by: Lucas Pasqualin <lpasqualin@meta.com>
@atalman atalman mentioned this pull request May 29, 2024
Closed
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fegin fegin fegin approved these changes

@wz337 wz337 wz337 approved these changes

Assignees

@LucasLLC LucasLLC

Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue topic: not user facing topic category
Projects
None yet
Milestone
2.3.1
Development

Successfully merging this pull request may close these issues.
6 participants
@LucasLLC @pytorchmergebot @huydhn @pytorchbot @fegin @wz337
0