[DCP][state_dict] Remove the check of FSDP has root #121544
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Root may not exist due to FSDP lazy initialization. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/121544
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 0a21915 with merge base 34a28f0 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Skylion007
approved these changes
Mar 9, 2024
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
wz337
added a commit
that referenced
this pull request
Mar 14, 2024
cc mrshenli pritamdamania87 zhaojuanmao satgera rohan-varma gqchen aazzolini osalpekar jiayisuse H-Huang kwen2501 awgu penguinwu fegin XilunWu wanchaol fduwjj tianyu-l wconstab yf225 chauhang LucasLLC Thanks fegin for removing the fsdp root module check in DCP to unblock test updates. #121544 This PR adds "optimzer_class" as a kwarg for the subtests of the following tests to add AdamW as an option. - test_fsdp - test_compiled_fsdp - test_fsdp2 - test_ddp - test_fsdp_ddp - test_cpu_offload_full_state_dict In addition, we temporarily remove the two _verify_osd_by_load in _test_save_load, as state dict loading seems affect parameters. Creating an issue #121186 to keep track. [ghstack-poisoned]
wz337
added a commit
that referenced
this pull request
Mar 14, 2024
cc mrshenli pritamdamania87 zhaojuanmao satgera rohan-varma gqchen aazzolini osalpekar jiayisuse H-Huang kwen2501 awgu penguinwu fegin XilunWu wanchaol fduwjj tianyu-l wconstab yf225 chauhang LucasLLC Thanks fegin for removing the fsdp root module check in DCP to unblock test updates. #121544 This PR adds "optimzer_class" as a kwarg for the subtests of the following tests to add AdamW as an option. - test_fsdp - test_compiled_fsdp - test_fsdp2 - test_ddp - test_fsdp_ddp - test_cpu_offload_full_state_dict In addition, we temporarily remove the two _verify_osd_by_load in _test_save_load, as state dict loading seems affect parameters. Creating an issue #121186 to keep track. [ghstack-poisoned]
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 15, 2024
Thanks @fegin for removing the fsdp root module check in DCP to unblock test updates. #121544 This PR adds "optimzer_class" as a kwarg for the subtests of the following tests to add AdamW as an option. - test_fsdp - test_compiled_fsdp - test_fsdp2 - test_ddp - test_fsdp_ddp - test_cpu_offload_full_state_dict In addition, we temporarily remove the two _verify_osd_by_load in _test_save_load, as state dict loading seems affect parameters. Creating an issue #121186 to keep track. Pull Request resolved: #121774 Approved by: https://github.com/Skylion007 ghstack dependencies: #121773
mvpatel2000
pushed a commit
to mvpatel2000/pytorch
that referenced
this pull request
May 17, 2024
Root may not exist due to FSDP lazy initialization. Pull Request resolved: pytorch#121544 Approved by: https://github.com/Skylion007 ghstack dependencies: pytorch#121273, pytorch#121276, pytorch#121290
This was referenced May 17, 2024
atalman
pushed a commit
that referenced
this pull request
May 27, 2024
Root may not exist due to FSDP lazy initialization. Pull Request resolved: #121544 Approved by: https://github.com/Skylion007 ghstack dependencies: #121273, #121276, #121290 Co-authored-by: Chien-Chin Huang <chienchin@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Root may not exist due to FSDP lazy initialization.
cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @wconstab @yf225 @chauhang @LucasLLC