Fix make triton command on release branch (#121169) #121229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes pytorch#120044 Should fix build from source instructions on release branch here: https://github.com/pytorch/pytorch#from-source Please note we are using /test/ channel for release here to make sure it works, before actual release is completed. Test main: ``` make triton pip3 uninstall -y triton WARNING: Skipping triton as it is not installed. Looking in indexes: https://download.pytorch.org/whl/nightly/ Collecting pytorch-triton==3.0.0+a9bc1a3647 Downloading https://download.pytorch.org/whl/nightly/pytorch_triton-3.0.0%2Ba9bc1a3647-cp310-cp310-linux_x86_64.whl (239.0 MB) ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 239.0/239.0 MB 8.7 MB/s eta 0:00:00 Requirement already satisfied: filelock in /home/atalman/miniconda3/envs/py310/lib/python3.10/site-packages (from pytorch-triton==3.0.0+a9bc1a3647) (3.13.1) Installing collected packages: pytorch-triton Attempting uninstall: pytorch-triton Found existing installation: pytorch-triton 2.2.0 Uninstalling pytorch-triton-2.2.0: Successfully uninstalled pytorch-triton-2.2.0 Successfully installed pytorch-triton-3.0.0+a9bc1a3647 ``` Test release/2.2: ``` make triton pip3 uninstall -y triton WARNING: Skipping triton as it is not installed. Looking in indexes: https://download.pytorch.org/whl/test/ Collecting pytorch-triton==2.2.0 Using cached https://download.pytorch.org/whl/test/pytorch_triton-2.2.0-cp310-cp310-linux_x86_64.whl (183.1 MB) Requirement already satisfied: filelock in /home/atalman/miniconda3/envs/py310/lib/python3.10/site-packages (from pytorch-triton==2.2.0) (3.13.1) Installing collected packages: pytorch-triton Attempting uninstall: pytorch-triton Found existing installation: pytorch-triton 3.0.0+a9bc1a3647 Uninstalling pytorch-triton-3.0.0+a9bc1a3647: Successfully uninstalled pytorch-triton-3.0.0+a9bc1a3647 Successfully installed pytorch-triton-2.2.0 ``` Pull Request resolved: pytorch#121169 Approved by: https://github.com/seemethere
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/121229
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 11 PendingAs of commit 7851745 with merge base a8bd593 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
malfet
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #120044
Should fix build from source instructions on release branch here: https://github.com/pytorch/pytorch#from-source
Please note we are using /test/ channel for release here to make sure it works, before actual release is completed.
Test main:
Test release/2.2:
Pull Request resolved: #121169 Approved by: https://github.com/seemethere
Fixes #ISSUE_NUMBER