8000 Remove ids_of_folded_args from test_triton_kernel_equal_to_1_arg by aakhundov · Pull Request #121192 · pytorch/pytorch · GitHub
[go: up one dir, main page]

Skip to content

Remove ids_of_folded_args from test_triton_kernel_equal_to_1_arg #121192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

aakhundov
Copy link
Contributor
@aakhundov aakhundov commented Mar 5, 2024

Stack from ghstack (oldest at bottom):

Summary: Due to the Triton pin update in #119457, test_triton_kernel_equal_to_1_arg started to break, as ids_of_folded_args has vanished from the upstream Triton codebase.

Test Plan:

$ python test/inductor/test_triton_kernels.py -k test_triton_kernel_equal_to_1_arg
...
----------------------------------------------------------------------
Ran 6 tests in 6.790s

OK

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang

Summary: Due to the Triton pin update in #119457, `test_triton_kernel_equal_to_1_arg` started to break, as `ids_of_folded_args` has vanished from the upstream Triton codebase.

Test Plan:

```
$ python test/inductor/test_triton_kernels.py -k test_triton_kernel_equal_to_1_arg
...
----------------------------------------------------------------------
Ran 6 tests in 6.790s

OK
```

[ghstack-poisoned]
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Mar 5, 2024
Copy link
pytorch-bot bot commented Mar 5, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/121192

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 97f60b1 with merge base 6566b3d (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

aakhundov added a commit that referenced this pull request Mar 5, 2024
Summary: Due to the Triton pin update in #119457, `test_triton_kernel_equal_to_1_arg` started to break, as `ids_of_folded_args` has vanished from the upstream Triton codebase.

Test Plan:

```
$ python test/inductor/test_triton_kernels.py -k test_triton_kernel_equal_to_1_arg
...
----------------------------------------------------------------------
Ran 6 tests in 6.790s

OK
```

ghstack-source-id: 1a7ef6f
Pull Request 
8000
resolved: #121192
@aakhundov aakhundov requested review from jansel, oulgen and bertmaher March 5, 2024 02:34
@aakhundov aakhundov mentioned this pull request Mar 5, 2024
@aakhundov aakhundov added ciflow/trunk Trigger trunk jobs on your pull request ciflow/inductor and removed module: inductor labels Mar 5, 2024
@aakhundov
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Ch 8000 eck the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

@aakhundov
Copy link
Contributor Author

@pytorchbot merge -f "unrelated failures (broken trunk)"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/aakhundov/11/head branch April 5, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0