8000 [EZ] Set maximum supported version of Python as 3.12 by malfet · Pull Request #119743 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[EZ] Set maximum supported version of Python as 3.12 #119743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[EZ] Set maximum supported version of Python as 3.12 #119743

wants to merge 1 commit into from

Conversation

malfet
Copy link
Contributor
@malfet malfet commented Feb 13, 2024 •
edited
Loading

Doesn't really affect anything other than metadata on PyPI website
Otherwise programming languages tab on https://pypi.org/project/torch/2.2.0/ shows supported version 3.8 to 3.10:
image

@malfet
[EZ] Set maximum supported version of Python as 3.12
c63c0ed 
Doesn't really affect anything other than metadata on PyPI website
@malfet malfet added this to the 2.2.1 milestone Feb 13, 2024
@malfet malfet requested a review from a team February 13, 2024 01:49
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Feb 13, 2024
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Feb 13, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/119743

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c63c0ed with merge base ea8e4fd (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@malfet malfet added release notes: build release notes category topic: bug fixes topic category and removed topic: not user facing topic category labels Feb 13, 2024
@malfet
Copy link
Contributor Author
malfet commented Feb 13, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 13, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

atalman pushed a commit to atalman/pytorch that referenced this pull request Feb 13, 2024
@malfet @atalman
[EZ] Set maximum supported version of Python as 3.12 (pytorch#119743)
7681373 
Doesn't really affect anything other than metadata on PyPI website
Otherwise programming languages tab on https://pypi.org/project/torch/2.2.0/ shows supported version 3.8 to 3.10:
<img width="239" alt="image" src="https://github.com/pytorch/pytorch/assets/2453524/e17f9982-8833-4cd8-b8d8-b2f1cb538548">

Pull Request resolved: pytorch#119743
Approved by: https://github.com/kit1980, https://github.com/Skylion007
This was referenced Feb 13, 2024
Merged
Closed
atalman added a commit that referenced this pull request Feb 13, 2024
@atalman @malfet
[EZ] Set maximum supported version of Python as 3.12 (#119743) (#119770)
4ae8665 
Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
resolved: #119743
@malfet
Copy link
Contributor Author
malfet commented Feb 14, 2024

@pytorchbot cherrypick

@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Feb 14, 2024

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: argument command: invalid choice: 'cherrypick' (choose from 'merge', 'revert', 'rebase', 'label', 'drci', 'cherry-pick', 'close')

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci,cherry-pick,close} ...

Try @pytorchbot --help for more info.

@malfet
Copy link
Contributor Author
malfet commented Feb 14, 2024

@pytorchbot cherry-pick

@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Feb 14, 2024

❌ 🤖 pytorchbot command failed:

@pytorchbot cherry-pick: error: the following arguments are required: --onto, -c/--classification

usage: @pytorchbot cherry-pick --onto ONTO [--fixes FIXES] -c
                               {regression,critical,fixnewfeature,docs,release}

Try @pytorchbot --help for more info.

@malfet
Copy link
Contributor Author
malfet commented Feb 14, 2024

@pytorchbot cherry-pick --onto release/2.2 --fixes "Doc glitch" -c docs

@pytorchbot
Copy link
Collaborator

Cherry picking #119743

Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x -X theirs 60148f1761c3d3b894ee5ed26f7baa3461ba5ff5 returned non-zero exit code 1

Auto-merging setup.py
The previous cherry-pick is now empty, possibly due to conflict resolution.
If you wish to commit it anyway, use:

    git commit --allow-empty

Otherwise, please use 'git cherry-pick --skip'
On branch cherry-pick-119743-by-pytorch_bot_bot_
You are currently cherry-picking commit 60148f1761c.
  (all conflicts fixed: run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

nothing to commit, working tree clean
Details for Dev Infra team Raised by workflow job

@atalman
Copy link
Contributor
atalman commented Feb 19, 2024

I can confirm I do see:

Classifier: Programming Language :: C++
Classifier: Programming Language :: Python :: 3
Classifier: Programming Language :: Python :: 3.8
Classifier: Programming Language :: Python :: 3.9
Classifier: Programming Language :: Python :: 3.10
Classifier: Programming Language :: Python :: 3.11
Classifier: Programming Language :: Python :: 3.12

@malfet malfet deleted the malfet-patch-17 branch March 9, 2024 18:22
@disenone disenone mentioned this pull request Mar 12, 2024
Open
@atalman atalman mentioned this pull request Jan 8, 2025
Closed
pytorchmergebot pushed a commit that referenced this pull request Jan 8, 2025
@atalman @pytorchmergebot
Set maximum supported version of Python as 3.13 (#144396)
e14c36d 
Same as #119743 Required for Release 2.6.0
Pull Request resolved: #144396
Approved by: https://github.com/Skylion007, https://github.com/albanD, https://github.com/malfet
pytorchbot pushed a commit that referenced this pull request Jan 8, 2025
@atalman @pytorchbot
Set maximum supported version of Python as 3.13 (#144396)
1544bc4 
Same as #119743 Required for Release 2.6.0
Pull Request resolved: #144396
Approved by: https://github.com/Skylion007, https://github.com/albanD, https://github.com/malfet

(cherry picked from commit e14c36d)
@pytorchbot pytorchbot mentioned this pull request Jan 8, 2025
Merged
atalman added a commit that referenced this pull request Jan 10, 2025
@pytorchbot @atalman
Set maximum supported version of Python as 3.13 (#144409)
8c03454 
Set maximum supported version of Python as 3.13 (#144396)

Same as #119743 Required for Release 2.6.0
Pull Request resolved: #144396
Approved by: https://github.com/Skylion007, https://github.com/albanD, https://github.com/malfet

(cherry picked from commit e14c36d)

Co-authored-by: atalman <atalman@fb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kit1980 kit1980 kit1980 approved these changes

@Skylion007 Skylion007 Skylion007 approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: build release notes category topic: bug fixes topic category
Projects
None yet
Milestone
2.2.1
Development

Successfully merging this pull request may close these issues.
6 participants
@malfet @pytorchmergebot @pytorchbot @atalman @kit1980 @Skylion007
0