8000 Migrate rocm test to using oidc (#117160) by atalman · Pull Request #119565 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Migrate rocm test to using oidc (#117160) #119565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 9, 2024
Merged

Migrate rocm test to using oidc (#117160) #119565

merged 2 commits into from
Feb 9, 2024

Conversation

atalman
Copy link
Contributor
@atalman atalman commented Feb 9, 2024 •
edited by pytorch-bot bot
Loading

Similar to Intel XPU, lets use OIDC for rocm runners.

Refer to this PR: #116554

Pull Request resolved: #117160
Approved by: https://github.com/huydhn, https://github.com/malfetFixes #ISSUE_NUMBER

cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang

atalman and others added 2 commits February 9, 2024 09:00
@atalman
Migrate rocm test to using oidc (pytorch#117160)
e468f08 
Similar to Intel XPU, lets use OIDC for rocm runners.

Refer to this PR: pytorch#116554

Pull Request resolved: pytorch#117160
Approved by: https://github.com/huydhn, https://github.com/malfet
@huydhn @atalman
The permission id-token write needs to be set on rocm-test callers (p…
80a1b20 
…ytorch#117422)

All these workflows lack the necessary permission to run `_rocm-test` job after pytorch#117160, for example https://github.com/pytorch/pytorch/actions/runs/7508520071

Confirm that trunk is back https://github.com/pytorch/pytorch/actions/runs/7508830196.  Other workflows would be the same, i.e. rocm https://github.com/pytorch/pytorch/actions/runs/7508830137/job/20444989127.

Pull Request resolved: pytorch#117422
Approved by: https://github.com/atalman
@atalman atalman requested a review from a team as a code owner February 9, 2024 17:04
@pytorch-bot pytorch-bot bot added ciflow/rocm Trigger "default" config CI on ROCm module: rocm AMD GPU support for Pytorch topic: not user facing topic category labels Feb 9, 2024
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Feb 9, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/119565

Note: Links to docs will display an error until the docs builds have been completed.

❌ 7 New Failures, 13 Unrelated Failures

As of commit 80a1b20 with merge base a8bd593 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@atalman atalman mentioned this pull request Feb 9, 2024
Closed
@atalman atalman merged commit e9956ba into pytorch:release/2.2 Feb 9, 2024
@atalman atalman deleted the rocm_oidc_change branch February 9, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huydhn huydhn huydhn approved these changes

Assignees
No one assigned
Labels
ciflow/rocm Trigger "default" config CI on ROCm module: rocm AMD GPU support for Pytorch topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atalman @huydhn
0