8000 [quant][pt2e][bc-breaking] Set `fold_quantize` to True in `convert_pt2e` by jerryzh168 · Pull Request #119425 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[quant][pt2e][bc-breaking] Set fold_quantize to True in convert_pt2e #119425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[quant][pt2e][bc-breaking] Set fold_quantize to True in convert_pt2e #119425

wants to merge 1 commit into from

Conversation

jerryzh168
Copy link
Contributor
@jerryzh168 jerryzh168 commented Feb 8, 2024 •
edited by pytorch-bot bot
Loading

Summary: This is a follow up to #118605 to set fold_quantize flag to True in convert_pt2e

Test Plan: CI

Differential Revision: D53550237

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler

@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Feb 8, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/119425

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d92de5f with merge base 91f0381 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: quantization release notes category label Feb 8, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53550237

jerryzh168 added a commit to jerryzh168/executorch-1 that referenced this pull request Feb 8, 2024
@jerryzh168 @facebook-github-bot
Set fold_quantize to True in convert_pt2e (pytorch#1882)
1f14958 
Summary:
X-link: pytorch/pytorch#119425


This is a follow up to pytorch/pytorch#118605 to set `fold_quantize` flag to True in `convert_pt2e`

Reviewed By: digantdesai

Differential Revision: D53550237
jerryzh168 added a commit to jerryzh168/pytorch that referenced this pull request Feb 8, 2024
@jerryzh168 @facebook-github-bot
[quant][pt2e][bc-breaking] Set fold_quantize to True in `convert_pt…
ab06ef4 
…2e` (pytorch#119425)

Summary:

X-link: pytorch/executorch#1882

This is a follow up to pytorch#118605 to set `fold_quantize` flag to True in `convert_pt2e`

Test Plan: CI

Reviewed By: digantdesai

Differential Revision: D53550237
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53550237

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 8, 2024
@jerryzh168 @facebook-github-bot
[quant][pt2e][bc-breaking] Set fold_quantize to True in `convert_pt…
d92de5f 
…2e` (pytorch#119425)

Summary:

X-link: pytorch/executorch#1882

This is a follow up to pytorch#118605 to set `fold_quantize` flag to True in `convert_pt2e`

Test Plan: CI

Reviewed By: digantdesai

Differential Revision: D53550237
jerryzh168 added a commit to jerryzh168/executorch-1 that referenced this pull request Feb 8, 2024
@jerryzh168 @facebook-github-bot
Set fold_quantize to True in convert_pt2e (pytorch#1882)
976abb1 
Summary:
X-link: pytorch/pytorch#119425


This is a follow up to pytorch/pytorch#118605 to set `fold_quantize` flag to True in `convert_pt2e`

Reviewed By: digantdesai

Differential Revision: D53550237
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53550237

facebook-github-bot pushed a commit to pytorch/executorch that referenced this pull request Feb 9, 2024
@jerryzh168 @facebook-github-bot
Set fold_quantize to True in convert_pt2e (#1882)
f7ce83c 
Summary:
X-link: pytorch/pytorch#119425

Pull Request resolved: #1882

This is a follow up to pytorch/pytorch#118605 to set `fold_quantize` flag to True in `convert_pt2e`

Reviewed By: digantdesai

Differential Revision: D53550237

fbshipit-source-id: fad66e5d860113d4510c605d86b8045eef4b449c
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

clee2000 pushed a commit that referenced this pull request Feb 14, 2024
@jerryzh168 @clee2000
[quant][pt2e][bc-breaking] Set fold_quantize to True in `convert_pt…
3ab3c31 
…2e` (#119425)

Summary: This is a follow up to #118605 to set `fold_quantize` flag to True in `convert_pt2e`

Test Plan: CI

Differential Revision: D53550237

Pull Request resolved: #119425
Approved by: https://github.com/andrewor14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewor14 andrewor14 andrewor14 approved these changes

@kimishpatel kimishpatel Awaiting requested review from kimishpatel

@digantdesai digantdesai Awaiting requested review from digantdesai

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged module: inductor release notes: quantization release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jerryzh168 @facebook-github-bot @pytorchmergebot @andrewor14
0