-
Notifications
You must be signed in to change notification settings - Fork 24.2k
[export] Remove torch._export.export #119095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/119095
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 3369881 with merge base 4f2bf7f ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This pull request was exported from Phabricator. Differential Revision: D53316196 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! So glad we're deprecating the old APIs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
expect some codemods
Was the old one widely used? |
777aeb5
to
bf8c737
Compare
Summary: Pull Request resolved: #119095 Test Plan: CI Reviewed By: ydwu4 Differential Revision: D53316196
This pull request was exported from Phabricator. Differential Revision: D53316196 |
bf8c737
to
0917c5f
Compare
Summary: Pull Request resolved: pytorch#119095 Test Plan: CI Reviewed By: tugsbayasgalan, ydwu4 Differential Revision: D53316196
This pull request was exported from Phabricator. Differential Revision: D53316196 |
return out_dtype( | ||
torch.ops.aten.add_.Tensor, torch.int32, x, y | ||
) | ||
class M(torch.nn.Module): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
function no longer supported?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not since #117528
Summary: Pull Request resolved: pytorch#119095 Test Plan: CI Reviewed By: avikchaudhuri, tugsbayasgalan, ydwu4 Differential Revision: D53316196
0917c5f
to
3369881
Compare
This pull request was exported from Phabricator. Differential Revision: D53316196 |
@pytorchbot merge -f 'Landed internally' (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
XLA changes: pytorch/xla#6486 Test Plan: CI Differential Revision: D53316196 Pull Request resolved: #119095 Approved by: https://github.com/ydwu4, https://github.com/zhxchen17, https://github.com/tugsbayasgalan, https://github.com/avikchaudhuri, https://github.com/jerryzh168
XLA changes: pytorch/xla#6486
Test Plan: CI
Differential Revision: D53316196
cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @wconstab @yf225 @voznesenskym @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @aakhundov @kadeng