8000 [export] Remove torch._export.export by angelayi · Pull Request #119095 · pytorch/pytorch · GitHub
[go: up one dir, main page]

Skip to content

[export] Remove torch._export.export #119095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Copy link
pytorch-bot bot commented Feb 2, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/119095

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 3369881 with merge base 4f2bf7f (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53316196

Copy link
Contributor
@ydwu4 ydwu4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! So glad we're deprecating the old APIs

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 3, 2024
Copy link
Contributor
@zhxchen17 zhxchen17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expect some codemods

@kit1980
Copy link
Contributor
kit1980 commented Feb 5, 2024

Was the old one widely used?
I can add this to https://github.com/pytorch-labs/torchfix/

@angelayi angelayi requested a review from jerryzh168 as a code owner February 6, 2024 18:22
pytorch-bot bot pushed a commit that referenced this pull request Feb 6, 2024
Summary: Pull Request resolved: #119095

Test Plan: CI

Reviewed By: ydwu4

Differential Revision: D53316196
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53316196

angelayi added a commit to angelayi/pytorch that referenced this pull request Feb 7, 2024
Summary: Pull Request resolved: pytorch#119095

Test Plan: CI

Reviewed By: tugsbayasgalan, ydwu4

Differential Revision: D53316196
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53316196

@github-actions github-actions bot added the oncall: distributed Add this issue/PR to distributed oncall triage queue label Feb 7, 2024
return out_dtype(
torch.ops.aten.add_.Tensor, torch.int32, x, y
)
class M(torch.nn.Module):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

function no longer supported?

Copy link
Contributor Author
8000

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not since #117528

Summary: Pull Request resolved: pytorch#119095

Test Plan: CI

Reviewed By: avikchaudhuri, tugsbayasgalan, ydwu4

Differential Revision: D53316196
@angelayi angelayi requested a review from a team as a code owner February 8, 2024 16:33
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53316196

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged module: dynamo oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: quantization release notes category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants
0