8000 Remove unnecessary skipIfTorchDynamo from test_jit_fuser_te by zou3519 · Pull Request #118728 · pytorch/pytorch · GitHub
[go: up one dir, main page]

Skip to content

Remove unnecessary skipIfTorchDynamo from test_jit_fuser_te #118728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

zou3519
Copy link
Contributor
@zou3519 zou3519 commented Jan 31, 2024

Stack from ghstack (oldest at bottom):

And add some expected failures.

And add some expected failures.

[ghstack-poisoned]
Copy link
pytorch-bot bot commented Jan 31, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/118728

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b13d844 with merge base 24bdd03 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

zou3519 added a commit that referenced this pull request Jan 31, 2024
And add some expected failures.

ghstack-source-id: 8dcd0cc
Pull Request resolved: #118728
@zou3519 zou3519 added topic: not user facing topic category keep-going Don't stop on first failure, keep running tests until the end labels Jan 31, 2024
And add some expected failures.

[ghstack-poisoned]
And add some expected failures.

[ghstack-poisoned]
And add some expected failures.

[ghstack-poisoned]
zou3519 added a commit that referenced this pull request Feb 12, 2024
And add some expected failures.

ghstack-source-id: cc0fad3
Pull Request resolved: #118728
@@ -344,7 +344,6 @@ def __init__(self):
self.bar = torch.jit.ScriptModule()


@skipIfTorchDynamo()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the point in running these with dynamo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've caught some interesting errors with them. We could skip them entirely if we want to.

@zou3519
Copy link
Contributor Author
zou3519 commented Feb 12, 2024

@pytorchbot merge -f "passed Dynamo CI"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

clee2000 pushed a commit that referenced this pull request Feb 14, 2024
And add some expected failures.
Pull Request resolved: #118728
Approved by: https://github.com/bdhirsh
@github-actions github-actions bot deleted the gh/zou3519/905/head branch March 14, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep-going Don't stop on first failure, keep running tests until the end Merged topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0