-
Notifications
You must be signed in to change notification settings - Fork 24.7k
Remove unnecessary skipIfTorchDynamo from test_jit_fuser_te #118728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
And add some expected failures. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/118728
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b13d844 with merge base 24bdd03 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
And add some expected failures. [ghstack-poisoned]
And add some expected failures. [ghstack-poisoned]
And add some expected failures. [ghstack-poisoned]
@@ -344,7 +344,6 @@ def __init__(self): | |||
self.bar = torch.jit.ScriptModule() | |||
|
|||
|
|||
@skipIfTorchDynamo() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the point in running these with dynamo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've caught some interesting errors with them. We could skip them entirely if we want to.
@pytorchbot merge -f "passed Dynamo CI" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
And add some expected failures. Pull Request resolved: #118728 Approved by: https://github.com/bdhirsh
Stack from ghstack (oldest at bottom):
And add some expected failures.