8000 Fix trition wheels build (take 2) by malfet · Pull Request #117706 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Fix trition wheels build (take 2) #117706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix trition wheels build (take 2) #117706

wants to merge 1 commit into from

Conversation

malfet
Copy link
Contributor
@malfet malfet commented Jan 17, 2024 •
edited
Loading

Sorry, I should have been more thorough in reviewing #117648 Triton wheels are built of main branch, rather than nightly, see

pytorch/.github/workflows/build-triton-wheel.yml

Lines 1 to 6 in 2db53a0

name: Build Triton wheels
on:
push:
branches:
- main

Test plan: merge and hope for the best :P

@malfet
Fix trition wheels build (take 2)
6f76362 
Sorry, I should have been more thorough in reviewing #117648
Triton wheels are build on main, not on nightly branch
@malfet malfet requested a review from a team as a code owner January 17, 2024 23:44
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jan 17, 2024
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Jan 17, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/117706

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 6f76362 with merge base 2db53a0 (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@huydhn
Copy link
Contributor
huydhn commented Jan 17, 2024 •
edited
Loading

@pytorchbot drci

(I want to see if pr-dep-check failure is marked as flaky, .. and it's gone)

@malfet
Copy link
Contributor Author
malfet commented Jan 18, 2024

@pytorchbot merge -f "Lint is green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet malfet mentioned this pull request Jan 18, 2024
Closed
@malfet malfet deleted the malfet-patch-45 branch January 18, 2024 01:26
atalman pushed a commit to atalman/pytorch that referenced this pull request Feb 9, 2024
@malfet @atalman
Fix trition wheels build (take 2) (pytorch#117706)
5624030 
Sorry, I should have been more thorough in reviewing pytorch#117648 Triton wheels are built of `main` branch, rather than `nightly`, see
https://github.com/pytorch/pytorch/blob/2db53a01e545636602572eeb2268c68500c5e47b/.github/workflows/build-triton-wheel.yml#L1-L6

Test plan: merge and hope for the best :P

Pull Request resolved: pytorch#117706
Approved by: https://github.com/huydhn, https://github.com/atalman
@atalman atalman mentioned this pull request Feb 9, 2024
Closed
atalman added a commit that referenced this pull request Feb 9, 2024
@atalman @malfet
[oidc] Migrate Triton wheel upload to oidc (#117648) (#119564)
574f46d 
Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
resolved: #117648
Fix trition wheels build (take 2) (#117706)
resolved: #117706
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huydhn huydhn huydhn approved these changes

@atalman atalman atalman approved these changes

Assignees
No one assigned
Labels
Merged topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@malfet @huydhn @pytorchmergebot @atalman
0