8000 [export] Remove CallSpec by angelayi · Pull Request #117671 · pytorch/pytorch · GitHub

[export] Remove CallSpec #117671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

angelayi wants to merge 1 commit into pytorch:main from angelayi:export-D52842563

Contributor

angelayi commented

Summary: This is not really being used anywhere

Test Plan: CI

Differential Revision: D52842563

angelayi requested review from avikchaudhuri, gmagogsfm, tugsbayasgalan and zhxchen17 as code owners

January 17, 2024 18:39

pytorch-bot bot commented

•

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/117671

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9a7d73d with merge base 6fe5a3a ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

github-actions bot added the ciflow/inductor label

Contributor

facebook-github-bot commented

This pull request was exported from Phabricator. Differential Revision: D52842563

facebook-github-bot added the fb-exported label

angelayi added a commit to angelayi/executorch-1 that referenced this pull request


          Remove CallSpec (pytorch#1618)

24823ef

Summary:
X-link: pytorch/pytorch#117671


This is not really being used anywhere

Differential Revision: D52842563

angelayi force-pushed the export-D52842563 branch from e4247f8 to c4ecf23 Compare

January 17, 2024 18:40

Contributor

facebook-github-bot commented

This pull request was exported from Phabricator. Differential Revision: D52842563

angelayi added a commit to angelayi/executorch-1 that referenced this pull request


          Remove CallSpec (pytorch#1618)

560030d

Summary:
X-link: pytorch/pytorch#117671


This is not really being used anywhere

Differential Revision: D52842563

angelayi force-pushed the export-D52842563 branch from c4ecf23 to ab6c74a Compare

January 17, 2024 18:50

Contributor

facebook-github-bot commented

This pull request was exported from Phabricator. Differential Revision: D52842563

avikchaudhuri approved these changes

View reviewed changes

Contributor

avikchaudhuri left a comment

Nice.

pytorch-bot bot added the ciflow/trunk label

angelayi added a commit to angelayi/executorch-1 that referenced this pull request


          Remove CallSpec (pytorch#1618)

Summary:
X-link: pytorch/pytorch#117671


This is not really being used anywhere

Differential Revision: D52842563

angelayi force-pushed the export-D52842563 branch from ab6c74a to c54cd71 Compare

January 17, 2024 21:34

angelayi added a commit to angelayi/pytorch that referenced this pull request


          [export] Remove CallSpec (pytorch#117671)

c54cd71

Summary:

X-link: pytorch/executorch#1618

This is not really being used anywhere

Test Plan: CI

Differential Revision: D52842563

Contributor

facebook-github-bot commented

This pull request was exported from Phabricator. Differential Revision: D52842563

angelayi force-pushed the export-D52842563 branch from c54cd71 to 78cbac1 Compare

January 22, 2024 18:40

angelayi added a commit to angelayi/executorch-1 that referenced this pull request


          Remove CallSpec (pytorch#1618)

86a8712

Summary:
X-link: pytorch/pytorch#117671


This is not really being used anywhere

Reviewed By: zhxchen17

Differential Revision: D52842563

angelayi added a commit to angelayi/pytorch that referenced this pull request


          [export] Remove CallSpec (pytorch#117671)

78cbac1

Summary:

X-link: pytorch/executorch#1618

This is not really being used anywhere

Test Plan: CI

Reviewed By: zhxchen17

Differential Revision: D52842563

Contributor

facebook-github-bot commented

This pull request was exported from Phabricator. Differential Revision: D52842563

zhxchen17 approved these changes

View reviewed changes

angelayi force-pushed the export-D52842563 branch from 78cbac1 to 8ee459a Compare

January 27, 2024 01:28

Contributor

facebook-github-bot commented

This pull request was exported from Phabricator. Differential Revision: D52842563

angelayi added a commit to angelayi/executorch-1 that referenced this pull request


          Remove CallSpec (pytorch#1618)

8e6801f

Summary:
X-link: pytorch/pytorch#117671


This is not really being used anywhere

Reviewed By: zhxchen17

Differential Revision: D52842563

angelayi added a commit to angelayi/executorch-1 that referenced this pull request


          Remove CallSpec (pytorch#1618)

4aae6e7

Summary:
X-link: pytorch/pytorch#117671


This is not really being used anywhere

Reviewed By: zhxchen17

Differential Revision: D52842563

angelayi added a commit to angelayi/pytorch that referenced this pull request


          [export] Remove CallSpec (pytorch#117671)

98ae506

Summary:

X-link: pytorch/executorch#1618

This is not really being used anywhere

Test Plan: CI

Reviewed By: zhxchen17

Differential Revision: D52842563

angelayi force-pushed the export-D52842563 branch from 8ee459a to 98ae506 Compare

January 27, 2024 01:29

Contributor

facebook-github-bot commented

This pull request was exported from Phabricator. Differential Revision: D52842563

Contributor

zhxchen17 commented

@angelayi still going?


          [export] Remove CallSpec (pytorch#117671)

9a7d73d

Summary:

X-link: pytorch/executorch#1618

This is not really being used anywhere

Test Plan: CI

Reviewed By: zhxchen17

Differential Revision: D52842563

angelayi force-pushed the export-D52842563 branch from 98ae506 to 9a7d73d Compare

February 7, 2024 22:26

Contributor

facebook-github-bot commented

This pull request was exported from Phabricator. Differential Revision: D52842563

Contributor

facebook-github-bot commented

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

Collaborator

pytorchmergebot commented

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot added the merging label

pytorchmergebot closed this in

c3e0836

pytorchmergebot added Merged and removed merging labels

pytorch-bot bot pushed a commit that referenced this pull request


          [export] Remove CallSpec (#117671)

811feed

Summary: This is not really being used anywhere

Test Plan: CI

Differential Revision: D52842563

Pull Request resolved: #117671
Approved by: https://github.com/avikchaudhuri, https://github.com/zhxchen17

clee2000 pushed a commit that referenced this pull request


          [export] Remove CallSpec (#117671)

f6199e0

Summary: This is not really being used anywhere

Test Plan: CI

Differential Revision: D52842563

Pull Request resolved: #117671
Approved by: https://github.com/avikchaudhuri, https://github.com/zhxchen17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

zhxchen17 zhxchen17 approved these changes

avikchaudhuri avikchaudhuri approved these changes

gmagogsfm Awaiting requested review from gmagogsfm

tugsbayasgalan Awaiting requested review from tugsbayasgalan tugsbayasgalan is a code owner

Labels

ciflow/inductor ciflow/trunk fb-exported Merged

0