8000 [export][refactor][6/n] Remove equality_constraints by angelayi · Pull Request #116979 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[export][refactor][6/n] Remove equality_constraints #116979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[export][refactor][6/n] Remove equality_constraints #116979

wants to merge 1 commit into from

Conversation

angelayi
Copy link
Contributor
@angelayi angelayi commented Jan 8, 2024 •
edited
Loading

Through the new dynamic_shapes API and using torch.export.Dim, dimensions that are equal will now be represented by the same symbol, so we no longer need to store equality_constraints.

Differential Revision: D52351705

@angelayi @facebook-github-bot
[export][refactor][6/n] Remove equality_constraints
5149185 
Test Plan: CI

Differential Revision: D52351705
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Jan 8, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/116979

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 5149185 with merge base 7073dc6 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52351705

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jan 8, 2024

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

avikchaudhuri
avikchaudhuri approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor
@avikchaudhuri avikchaudhuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are you going to land this internally? Will this require a change to executorch as well?

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 9, 2024
@angelayi
Copy link
Contributor Author
angelayi commented Jan 9, 2024

The internal diff D52351705 is on top of a stack of diffs that have already been landed which migrated ppl off of equality constraints. Since CI is green for both internal and external I expect this diff to be good to go? :>

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

xadupre pushed a commit to xadupre/pytorch that referenced this pull request Jan 10, 2024
@angelayi @xadupre
[export][refactor][6/n] Remove equality_constraints (pytorch#116979)
6f38c1a 
Through the new dynamic_shapes API and using torch.export.Dim, dimensions that are equal will now be represented by the same symbol, so we no longer need to store `equality_constraints`.

Differential Revision: D52351705

Pull Request resolved: pytorch#116979
Approved by: https://github.com/avikchaudhuri
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avikchaudhuri avikchaudhuri avikchaudhuri approved these changes

@gmagogsfm gmagogsfm Awaiting requested review from gmagogsfm

@tugsbayasgalan tugsbayasgalan Awaiting requested review from tugsbayasgalan tugsbayasgalan is a code owner

@zhxchen17 zhxchen17 Awaiting requested review from zhxchen17 zhxchen17 is a code owner

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@angelayi @facebook-github-bot @pytorchmergebot @avikchaudhuri
0