8000 delete sharded tensor from fsdp/tp tests by wanchaol · Pull Request #116244 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

delete sharded tensor from fsdp/tp tests #116244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

delete sharded tensor from fsdp/tp tests #116244

wants to merge 4 commits into from

Conversation

wanchaol
Copy link
Collaborator
@wanchaol wanchaol commented Dec 21, 2023 •
edited
Loading

@wanchaol wanchaol mentioned this pull request Dec 21, 2023
Closed
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Dec 21, 2023
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Dec 21, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/116244

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 017c5ce with merge base 0e63837 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

wanchaol added a commit that referenced this pull request Dec 21, 2023
@wanchaol
delete sharded tensor from fsdp/tp tests
9b84dca 
ghstack-source-id: 2f6e73c
Pull Request resolved: #116244
@github-actions github-actions bot added the oncall: distributed Add this issue/PR to distributed oncall triage queue label Dec 21, 2023
@wanchaol wanchaol requested review from awgu and wz337 December 21, 2023 16:58
awgu
awgu approved these changes Dec 21, 2023
View reviewed changes
Copy link
Collaborator
@awgu awgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wanchaol wanchaol added the ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR label Dec 22, 2023
wz337
wz337 approved these changes Dec 25, 2023
View reviewed changes
Copy link
Contributor
@wz337 wz337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@wanchaol
Update on "delete sharded tensor from fsdp/tp tests"
bd91f9e 
cc mrshenli pritamdamania87 zhaojuanmao satgera rohan-varma gqchen aazzolini osalpekar jiayisuse H-Huang kwen2501 awgu penguinwu fegin XilunWu fduwjj wz337 tianyu-l wconstab yf225

[ghstack-poisoned]
This was referenced Dec 26, 2023
Closed
Closed
@wanchaol
Update on "delete sharded tensor from fsdp/tp tests"
604db02 
cc mrshenli pritamdamania87 zhaojuanmao satgera rohan-varma gqchen aazzolini osalpekar jiayisuse H-Huang kwen2501 awgu penguinwu fegin XilunWu fduwjj wz337 tianyu-l wconstab yf225

[ghstack-poisoned]
@wanchaol wanchaol mentioned this pull request Dec 30, 2023
Closed
@wanchaol
Update on "delete sharded tensor from fsdp/tp tests"
017c5ce 
cc mrshenli pritamdamania87 zhaojuanmao satgera rohan-varma gqchen aazzolini osalpekar jiayisuse H-Huang kwen2501 awgu penguinwu fegin XilunWu fduwjj wz337 tianyu-l wconstab yf225

[ghstack-poisoned]
@wanchaol wanchaol mentioned this pull request Dec 31, 2023
Closed
@wanchaol wanchaol added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 2, 2024
@wanchaol
Copy link
Collaborator Author
wanchaol commented Jan 2, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/wanchaol/418/head branch January 6, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fduwjj fduwjj fduwjj approved these changes

@awgu awgu awgu approved these changes

@wz337 wz337 wz337 approved these changes

Assignees
No one assigned
Labels
ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wanchaol @pytorchmergebot @fduwjj @awgu @wz337
0