8000 [releng] Docker release, Change docker tag. Refactor Push nightly tags step. Move cuda and cudnn version to docker tag rather then name by atalman · Pull Request #116098 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[releng] Docker release, Change docker tag. Refactor Push nightly tags step. Move cuda and cudnn version to docker tag rather then name #116098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 19, 2023
Merged

[releng] Docker release, Change docker tag. Refactor Push nightly tags step. Move cuda and cudnn version to docker tag rather then name #116098

merged 3 commits into from
Dec 19, 2023

Conversation

atalman
Copy link
Contributor
@atalman atalman commented Dec 19, 2023 •
edited
Loading

@atalman
[releng] Docker Official release make sure cuda version is part of im…
e4e1a1a 
…age name (pytorch#116070)

Follow up on pytorch#115949

Change docker build image name:
``pytorch:2.1.2-devel``-> ``2.1.2-cuda12.1-cudnn8-devel and 2.1.2-cuda11.8-cudnn8-devel``

Ref: https://github.com/orgs/pytorch/packages/container/package/pytorch-nightly

Naming will be same as in https://hub.docker.com/r/pytorch/pytorch/tags
Pull Request resolved: pytorch#116070
Approved by: https://github.com/huydhn, https://github.com/seemethere
@atalman
[releng] Docker release Refactor Push nightly tags step. Move cuda an…
e69010d 
…d cudnn version to docker tag rather then name (pytorch#116097)

Follow up after : pytorch#116070

This PR does 2 things.

1. Refactor Push nightly tags step, don't need to extract CUDA_VERSION anymore. New tag should be in this format: ``${PYTORCH_VERSION}-cuda$(CUDA_VERSION_SHORT)-cudnn$(CUDNN_VERSION)-runtime``
2. Move cuda$(CUDA_VERSION_SHORT)-cudnn$(CUDNN_VERSION) from docker name to tag

Pull Request resolved: pytorch#116097
Approved by: https://github.com/jeanschmidt
@atalman atalman requested a review from a team as a code owner December 19, 2023 13:58
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Dec 19, 2023
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Dec 19, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/116098

Note: Links to docs will display an error until the docs builds have been completed.

❌ 32 New Failures, 11 Unrelated Failures

As of commit 0b58c94 with merge base 138e289 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@atalman atalman merged commit a545ebf into pytorch:release/2.1 Dec 19, 2023
@atalman atalman mentioned this pull request Dec 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@atalman
0