Windows Dynamo Error Removal CI Check #115969
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/115969
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 44497f9 with merge base 46ef735 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
5ad58b5 to
ecca64a
Compare
23ba8ef to
ea97c2f
Compare
We've had developers using Dynamo via torch.compile and torch._dynamo.export for months on Windows via SHARK (by just deleting these lines locally). I expect this reflects that some backends do not support Windows yet? If so, could the check be moved to those backends vs blocking all use?
0cb15d0 to
44497f9
Compare
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This reverts commit 45e7af5. Reverted #115969 on behalf of https://github.com/PaliC due to this pr ended up breaking some of our periodic tests ([comment](#115969 (comment)))
This PR was reopened (likely due to being reverted), so your approval was removed. Please request another review.
they seem to be flaky tests, actually. Is there any specific test that is valid? |
Rebase of #111313 onto `main`, for CI validation Co-authored-by: Stella Laurenzo <stellaraccident@gmail.com> Pull Request resolved: #115969 Approved by: https://github.com/ezyang
I don't understand how these test failures are related to the changes in this PR, which only changes which tests are skipped on Windows/non-inductor-supported platforms. |
I believe its referring to the unexpected success on the windows job https://github.com/pytorch/pytorch/actions/runs/7844639479/job/21408646820 |
|
Yeah I referring to the windows job. The job was passing on the 4 commits prior to this one, and failing consistently afterwards. Though given the job is still failing, it's likely an infra issue that happened to coincide with your pr (sorry :( ) @pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 2 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
|
@pytorchbot merge -f "Unrelated lint error: /exec: line 6: .github/scripts/lintrunner.sh: No such file or directory" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Link to landed trunk PR (if applicable): * pytorch#115969 Criteria Category: * Low risk critical fixes for backwards compatibility Approved-by: PaliC, thiagocrepaldi
Link to landed trunk PR (if applicable): * pytorch#115969 Criteria Category: * Low risk critical fixes for backwards compatibility Approved-by: PaliC, thiagocrepaldi
Link to landed trunk PR (if applicable): * #115969 Criteria Category: * Low risk critical fixes for backwards compatibility Approved-by: PaliC, thiagocrepaldi
Rebase of #111313 onto
main, for CI validationcc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @aakhundov @kadeng