10000 Fix mkldnn_matmul error on AArch64 by imzhuhl · Pull Request #114851 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Fix mkldnn_matmul error on AArch64 #114851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2023
Merged

Fix mkldnn_matmul error on AArch64 #114851

merged 1 commit into from
Nov 30, 2023

Conversation

imzhuhl
Copy link
Contributor
@imzhuhl imzhuhl commented Nov 30, 2023 •
edited by atalman
Loading

Fixes #110149

Cherry pick #110150. This is a bug fix against 2.1 release

@pytorch-bot pytorch-bot bot added the release notes: linalg_frontend release notes category label Nov 30, 2023
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Nov 30, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/114851

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 99d8f50 with merge base 138e289 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@imzhuhl imzhuhl mentioned this pull request Nov 30, 2023
Closed
@lezcano lezcano removed their request for review November 30, 2023 10:14
@atalman
Copy link
Contributor
atalman commented Nov 30, 2023

Tested #110149 with 2.1 release

(test1) [ec2-user@ip-10-0-34-249 temp]$ python test.py
Traceback (most recent call last):
  File "/home/ec2-user/actions-runner/temp/test.py", line 16, in <module>
    model(x)
  File "/home/ec2-user/miniconda3/envs/test1/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/home/ec2-user/miniconda3/envs/test1/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1527, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/ec2-user/actions-runner/temp/test.py", line 9, in forward
    x = self.fc(x)
  File "/home/ec2-user/miniconda3/envs/test1/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/home/ec2-user/miniconda3/envs/test1/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1527, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/ec2-user/miniconda3/envs/test1/lib/python3.10/site-packages/torch/nn/modules/linear.py", line 114, in forward
    return F.linear(input, self.weight, self.bias)
RuntimeError: could not create a primitive descriptor for a matmul primitive

with release 2.0 its passing.

@malfet malfet merged commit 3183bcd into pytorch:release/2.1 Nov 30, 2023
@malfet malfet mentioned this pull request Nov 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet approved these changes

@atalman atalman atalman approved these changes

@nikitaved nikitaved Awaiting requested review from nikitaved nikitaved is a code owner

@IvanYashchuk IvanYashchuk Awaiting requested review from IvanYashchuk IvanYashchuk is a code owner

Assignees
No one assigned
Labels
open source release notes: linalg_frontend release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@imzhuhl @atalman @malfet @pytorchbot
0