[Caffe2] Handle cpuinfo_initialize() failure
#114011
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can fail on ARM platform if `/sys` folder is not accessible In that case, call `std::thread::hardware_concurrency()`, which is aligned with the thread_pool initialization logic of `c10::TaskThreadPoolBase:defaultNumThreads()` Further addresses issue raised in #113568 [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/114011
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit b3c85d7 with merge base 9146ca6 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
malfet
added a commit
that referenced
this pull request
Nov 18, 2023
It can fail on ARM platform if `/sys` folder is not accessible In that case, call `std::thread::hardware_concurrency()`, which is aligned with the thread_pool initialization logic of `c10::TaskThreadPoolBase:defaultNumThreads()` Further addresses issue raised in #113568 ghstack-source-id: 29cc4a2 Pull Request resolved: #114011
8000
kit1980
approved these changes
Nov 18, 2023
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
malfet
added a commit
that referenced
this pull request
Nov 22, 2023
It can fail on ARM platform if `/sys` folder is not accessible. In that case, call `std::thread::hardware_concurrency()`, which is aligned with the thread_pool initialization logic of `c10::TaskThreadPoolBase:defaultNumThreads()` Further addresses issue raised in #113568 This is a cherry-pick of #114011 into release/2.1 branch (cherry picked from commit 310e306)
atalman
pushed a commit
that referenced
this pull request
Nov 23, 2023
It can fail on ARM platform if `/sys` folder is not accessible. In that case, call `std::thread::hardware_concurrency()`, which is aligned with the thread_pool initialization logic of `c10::TaskThreadPoolBase:defaultNumThreads()` Further addresses issue raised in #113568 This is a cherry-pick of #114011 into release/2.1 branch (cherry picked from commit 310e306)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cpuinfo_initialize()failure #114011It can fail on ARM platform if
/sysfolder is not accessible.In that case, call
std::thread::hardware_concurrency(), which isaligned with the thread_pool initialization logic of
c10::TaskThreadPoolBase:defaultNumThreads()Further addresses issue raised in #113568